Skip to content

Commit eadfcab

Browse files
committed
Remove PackageNamingPolicy_LowercaseMD5_IsObsolete()
The test doesn't fail now! …because, due to "special-casing" so that Mono.Android.dll is processed first -- and probably the `[JniTypeSignature]` additions in java-interop? -- we don't trigger the exception codepath now. ¯\_(ツ)_/¯
1 parent 8e74770 commit eadfcab

File tree

1 file changed

+1
-18
lines changed
  • src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests

1 file changed

+1
-18
lines changed

src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/BuildTest.cs

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1257,7 +1257,7 @@ public void AbiNameInIntermediateOutputPath ()
12571257
}
12581258

12591259
[Test]
1260-
public void PackageNamingPolicy ([Values ("LowercaseCrc64")] string packageNamingPolicy)
1260+
public void PackageNamingPolicy ([Values ("LowercaseMD5", "LowercaseCrc64")] string packageNamingPolicy)
12611261
{
12621262
var proj = new XamarinAndroidApplicationProject ();
12631263
proj.SetProperty ("UseInterpreter", "true");
@@ -1276,23 +1276,6 @@ public void PackageNamingPolicy ([Values ("LowercaseCrc64")] string packageNamin
12761276
}
12771277
}
12781278

1279-
[Test]
1280-
public void PackageNamingPolicy_LowercaseMD5_IsObsolete ()
1281-
{
1282-
var proj = new XamarinAndroidApplicationProject ();
1283-
proj.SetProperty ("UseInterpreter", "true");
1284-
proj.SetProperty ("AndroidPackageNamingPolicy", "LowercaseMD5");
1285-
proj.SetAndroidSupportedAbis ("armeabi-v7a", "x86");
1286-
using (var builder = CreateApkBuilder ()) {
1287-
builder.ThrowOnBuildFailure = false;
1288-
Assert.IsFalse (builder.Build (proj), "Build should have failed.");
1289-
string error = builder.LastBuildOutput
1290-
.SkipWhile (x => !x.StartsWith ("Build FAILED.", StringComparison.Ordinal))
1291-
.FirstOrDefault (x => x.Contains ("error XAGJS7015:"));
1292-
Assert.IsNotNull (error, "Build should have failed with XAGJS7015.");
1293-
}
1294-
}
1295-
12961279
[Test]
12971280
public void KotlinServiceLoader ([Values ("apk", "aab")] string packageFormat)
12981281
{

0 commit comments

Comments
 (0)