Skip to content

Commit 647ff3a

Browse files
authored
Build.proj: pass TreatWarningsAsErrors to Restore when '--warnaserror false'. (#15880)
1 parent d3a9e0b commit 647ff3a

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

src/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,9 +248,18 @@
248248
</_ProjectToRestore>
249249
</ItemGroup>
250250

251+
<!--
252+
Filter TreatWarningsAsErrors during Restore so CLI script builds and Visual Studio builds restore the same.
253+
Don't ignore it when it set to 'false' to apply '-warnaserror false' from CLI script builds.
254+
-->
255+
<PropertyGroup>
256+
<_RestoreRemoveProps>$(_RemoveProps)</_RestoreRemoveProps>
257+
<_RestoreRemoveProps Condition="'$(TreatWarningsAsErrors)' != 'false'">$(_RestoreRemoveProps);TreatWarningsAsErrors</_RestoreRemoveProps>
258+
</PropertyGroup>
259+
251260
<MSBuild Projects="@(_ProjectToRestore)"
252261
Properties="@(_SolutionRestoreProps)"
253-
RemoveProperties="$(_RemoveProps);TreatWarningsAsErrors"
262+
RemoveProperties="$(_RestoreRemoveProps)"
254263
Targets="Restore"
255264
SkipNonexistentTargets="true"
256265
BuildInParallel="%(_ProjectToRestore.RestoreInParallel)"

0 commit comments

Comments
 (0)