-
Notifications
You must be signed in to change notification settings - Fork 370
Flowing the .NET SDK version dependency #811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Wait until core-sdk onboards to BAR publishing. |
This is not required for preview 2 |
Since they are in, this something we could pick up, right? |
+1 Now that they publish to BAR, how do we do this?
It looks like their asset names include versions. Doesn't this prevent them from being referenced in Version.Details.xml? |
This needs changes in darc since it doesn't know about the existence of this version. Also, there are ongoing discussions on whether we should move to 3.0 yet or not. After that closes, I'll work on this change |
I'm going to follow the same approach we follow in dotnet/toolset. I'll create a fake internal package with a static name and that's the one that will be referenced. |
Focusing on this one again now that the urgent dependency update bug was taken care of. |
I see this issue as having two pieces:
|
CCing @chcosta as he's working on a solution for multiple shared frameworks |
Part 1 of this issue should be ready. We'll need to wait for a clean build of Core-SDK for the new Still working on updating the global.json sdk versions if they are older than what Arcade is flowing. |
The automatic flowing of the sdk version via Arcade dependency updates when the repo is using an older version of the sdk than what arcade uses has been rolled out, and today's dependency update PRs already include that. For example dotnet/coreclr#23718 The change to core-sdk publishing a stable package had to be reverted. And I filed #2426 to track re-enabling that flow. Also filed #2427 so that we include that we're updating these versions in the PR description. |
We should pick the sdk version from the global.json file from arcade and flow that to the repo's that subscribe to arcade. The toolset needs to match so that we can ensure the tools we are building will run in the repo's that are consuming arcade, as well as we have a consistent toolset across the repos.
The text was updated successfully, but these errors were encountered: