Skip to content

Commit 24a7615

Browse files
authored
Don't sign JS files (#13039)
We have .js files in our templates that are currently getting signed in our official builds. We don't want this, nor signing .py files. Exclude them both the same way - Update + CertificateName=None.
1 parent 733bd38 commit 24a7615

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

eng/Signing.props

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,15 @@
33
<ItemGroup>
44
<FileExtensionSignInfo Update=".nupkg" CertificateName="NuGet" />
55
<FileExtensionSignInfo Update=".zip" CertificateName="None" />
6-
<FileExtensionSignInfo Update=".js" CertificateName="MicrosoftDotNet500" />
76
<FileExtensionSignInfo Update=".vsix" CertificateName="VsixSHA2" />
87

98
<!-- add missing entry for .msi, this can be removed once aspire uses arcade 10.0 -->
109
<FileExtensionSignInfo Include=".msi" CertificateName="MicrosoftDotNet500" Condition="!@(FileExtensionSignInfo->AnyHaveMetadataValue('Identity', '.msi'))" />
1110

11+
<!-- We don't need to code sign .js files because they are not used in Windows Script Host. -->
12+
<FileExtensionSignInfo Update=".js" CertificateName="None" />
1213
<!-- Remove .py files from being signed. See https://github.com/dotnet/aspire/issues/13004 -->
13-
<FileExtensionSignInfo Remove=".py" />
14+
<FileExtensionSignInfo Update=".py" CertificateName="None" />
1415
</ItemGroup>
1516

1617
<ItemGroup>
@@ -51,10 +52,6 @@
5152
<FileSignInfo Condition="$([System.OperatingSystem]::IsWindows())" Include="manifest.cat" CertificateName="MicrosoftDotNet500" />
5253
</ItemGroup>
5354

54-
<PropertyGroup>
55-
<NoSignJS>true</NoSignJS>
56-
</PropertyGroup>
57-
5855
<ItemGroup>
5956
<ItemsToSign Include="$(VisualStudioSetupInsertionPath)\**\*.msi" Condition="'$(PostBuildSign)' != 'true'" />
6057
<ItemsToSign Include="$(ArtifactsPackagesDir)**\*.wixpack.zip" Condition="'$(PostBuildSign)' != 'true'" />

0 commit comments

Comments
 (0)