Avoid list copy on every update

By changing the set of subscriptions to an immutable collection and using optimistic locking to update it, we avoid having to copy the list of subscribers within a lock on every update, reducing allocations and the scope of synchronised blocks.

Author: drewnoakes

src/Aspire.Hosting/Dashboard/ViewModelProcessor.cs

@@ -1,6 +1,7 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+using System.Collections.Immutable;
 using System.Threading.Channels;
 using Aspire.Dashboard.Model;
 
@@ -13,7 +14,7 @@ internal sealed class ViewModelProcessor<TViewModel>
     private readonly Channel<ResourceChanged<TViewModel>> _incomingChannel;
     private readonly CancellationToken _cancellationToken;
     private readonly Dictionary<string, TViewModel> _snapshot = [];
-    private readonly List<Channel<ResourceChanged<TViewModel>>> _subscribedChannels = [];
+    private ImmutableHashSet<Channel<ResourceChanged<TViewModel>>> _outgoingChannels = [];
 
     public ViewModelProcessor(Channel<ResourceChanged<TViewModel>> incomingChannel, CancellationToken cancellationToken)
     {
@@ -28,18 +29,15 @@ public ViewModelMonitor<TViewModel> GetResourceMonitor()
         {
             var snapshot = _snapshot.Values.ToList();
             var channel = Channel.CreateUnbounded<ResourceChanged<TViewModel>>();
-            _subscribedChannels.Add(channel);
+            ImmutableInterlocked.Update(ref _outgoingChannels, static (set, channel) => set.Add(channel), channel);
             var enumerable = new ChangeEnumerable(channel, RemoveChannel);
 
             return new ViewModelMonitor<TViewModel>(snapshot, enumerable);
         }
-    }
 
-    private void RemoveChannel(Channel<ResourceChanged<TViewModel>> channel)
-    {
-        lock (_syncLock)
+        void RemoveChannel(Channel<ResourceChanged<TViewModel>> channel)
         {
-            _subscribedChannels.Remove(channel);
+            ImmutableInterlocked.Update(ref _outgoingChannels, static (set, channel) => set.Remove(channel), channel);
         }
     }
 
@@ -96,11 +94,11 @@ private async Task ProcessChanges()
     {
         await foreach (var change in _incomingChannel.Reader.ReadAllAsync(_cancellationToken))
         {
-            List<Channel<ResourceChanged<TViewModel>>> outgoingChannels;
+            var (changeType, resource) = change;
+
             lock (_syncLock)
             {
-                var resource = change.Resource;
-                switch (change.ObjectChangeType)
+                switch (changeType)
                 {
                     case ObjectChangeType.Added:
                         _snapshot.Add(resource.Name, resource);
@@ -114,11 +112,9 @@ private async Task ProcessChanges()
                         _snapshot.Remove(resource.Name);
                         break;
                 }
-
-                outgoingChannels = _subscribedChannels.ToList();
             }
 
-            foreach (var channel in outgoingChannels)
+            foreach (var channel in _outgoingChannels)
             {
                 await channel.Writer.WriteAsync(change, _cancellationToken).ConfigureAwait(false);
             }