Update WaitForResourceHealthyAsync to use DefaultWaitBehavior (#7738)

Co-authored-by: afscrome <[email protected]>

Author: github-actions[bot]

src/Aspire.Hosting/ApplicationModel/ResourceNotificationService.cs

@@ -242,7 +242,7 @@ public async Task<ResourceEvent> WaitForResourceHealthyAsync(string resourceName
     {
         return await WaitForResourceHealthyAsync(
             resourceName,
-            WaitBehavior.WaitOnResourceUnavailable, // Retain default behavior.
+            DefaultWaitBehavior,
             cancellationToken).ConfigureAwait(false);
     }
 

tests/Aspire.Hosting.Tests/WaitForTests.cs

@@ -242,6 +242,34 @@ await app.ResourceNotifications.WaitForResourceHealthyAsync(
       Assert.Equal("The operation has timed out.", ex.Message);
    }
 
+    [Theory]
+    [InlineData(WaitBehavior.WaitOnResourceUnavailable, typeof(TimeoutException), "The operation has timed out.")]
+    [InlineData(WaitBehavior.StopOnResourceUnavailable, typeof(DistributedApplicationException), "Stopped waiting for resource 'redis' to become healthy because it failed to start.")]
+    public async Task WhenWaitBehaviorIsMissingWaitForResourceHealthyAsyncShouldUseDefaultWaitBehavior(WaitBehavior defaultWaitBehavior, Type exceptionType, string exceptionMessage)
+    {
+        using var builder = TestDistributedApplicationBuilder.Create().WithTestAndResourceLogging(testOutputHelper);
+
+        builder.Services.Configure<ResourceNotificationServiceOptions>(o =>
+        {
+            o.DefaultWaitBehavior = defaultWaitBehavior;
+        });
+
+        var failToStart = builder.AddExecutable("failToStart", "does-not-exist", ".");
+        var dependency = builder.AddContainer("redis", "redis");
+
+        dependency.WaitFor(failToStart, WaitBehavior.StopOnResourceUnavailable);
+
+        using var app = builder.Build();
+        await app.StartAsync();
+
+        var ex = await Assert.ThrowsAsync(exceptionType, async () => {
+            await app.ResourceNotifications.WaitForResourceHealthyAsync(dependency.Resource.Name)
+                .WaitAsync(TimeSpan.FromSeconds(15));
+        });
+
+        Assert.Equal(exceptionMessage, ex.Message);
+    }
+
     [Theory]
     [InlineData(nameof(KnownResourceStates.Exited))]
     [InlineData(nameof(KnownResourceStates.FailedToStart))]