Skip to content

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Jun 30, 2025

Description

Fixes #10013

Before:

image

After:

image

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the interaction services by updating dialog styling in the dashboard and migrating interaction command definitions into a separate file for stress testing. Key changes include updated CSS variables and styling for dialogs, assigning an ID to the interaction dialog, and moving several interaction commands from the main app host file into a dedicated commands file.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/Aspire.Dashboard/wwwroot/css/app.css Updated CSS variables and added max-height/overflow properties for dialogs to enhance visual consistency in light and dark modes.
src/Aspire.Dashboard/Components/Interactions/InteractionsProvider.cs Assigned a unique dialog ID for input interactions.
playground/Stress/Stress.AppHost/Program.cs Removed interaction command definitions and added an extension method call for interaction commands.
playground/Stress/Stress.AppHost/InteractionCommands.cs Introduced a dedicated file with the full suite of interaction commands.

@JamesNK JamesNK merged commit 392b5fd into main Jun 30, 2025
252 checks passed
@JamesNK JamesNK deleted the jamesnk/input-height branch June 30, 2025 03:01
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Darken dialogs displayed in dashboard darkmode

3 participants