Fix deployment state file case sensitivity issue on Linux #13103
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When loading deployment state, the environment name was not normalized to lowercase, causing a mismatch with the saved state file on case-sensitive file systems (Linux/macOS). FileDeploymentStateManager saves files with lowercase environment names (e.g., production.json), but LoadDeploymentState in DistributedApplicationBuilder was using the original casing (e.g., Production.json), causing cache loading to fail unless the exact casing was specified with --environment flag. Changes: - Normalized environment name to lowercase in LoadDeploymentState method - Updated test to use lowercase filename to match actual behavior Fixes the issue where aspire deploy would only work with explicit --environment production flag on Linux.
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 13103Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 13103" |
davidfowl
approved these changes
Nov 21, 2025
Member
davidfowl
left a comment
davidfowl
left a comment
There was a problem hiding this comment.
This is a breaking change right?
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a case sensitivity bug in deployment state file caching on Linux and macOS systems. The bug occurred because FileDeploymentStateManager saves state files with lowercase environment names (using .ToLowerInvariant()), but DistributedApplicationBuilder.LoadDeploymentState was using the original casing from EnvironmentName, causing file lookups to fail on case-sensitive filesystems.
Key Changes
- Fixed: Added
.ToLowerInvariant()normalization inLoadDeploymentStateto matchFileDeploymentStateManagerbehavior - Corrected test: Updated test filename from
Production.jsontoproduction.jsonto reflect actual runtime behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Aspire.Hosting/DistributedApplicationBuilder.cs | Applied .ToLowerInvariant() to environment name when constructing deployment state path, ensuring consistency with file save logic |
| tests/Aspire.Hosting.Azure.Tests/AzureDeployerTests.cs | Corrected test filename to use lowercase production.json matching the actual file system behavior |
Contributor
Author
I don't think so. Looks more like a bug-fix to me 🤔 (for linux). In windows you can't have |
Contributor
|
@vhvb1989 I suspect there is another place where this is an issue. I could reproduce the problem on Debian 12 and workaround with |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #13102 - a case sensitivity bug in deployment state file caching on Linux and macOS systems that prevented
aspire deployfrom loading cached deployment state unless an explicit--environmentflag with the exact casing was provided.Problem
When running
aspire deployon Linux/macOS, the deployment state cache was not being loaded properly due to a case mismatch in environment name handling:FileDeploymentStateManagersaves state files with lowercase environment names (e.g.,production.json)DistributedApplicationBuilder.LoadDeploymentStatewas using the original casing fromEnvironmentName(e.g.,Production.json)Since Linux and macOS filesystems are case-sensitive, this caused cache loading to fail silently. The deployment would work only when explicitly specifying
aspire deploy --environment production(lowercase).Solution
Normalized the environment name to lowercase in
LoadDeploymentStatemethod using.ToLowerInvariant()to match the behavior inFileDeploymentStateManager.GetStatePath().Changes
.ToLowerInvariant()to environment name when constructing deployment state pathproduction.jsoninstead ofProduction.jsonto reflect actual behaviorTesting
DeployAsync_WithCachedDeploymentState_LoadsFromCachepasses with updated filenameFileDeploymentStateManager.GetStatePath()implementationDeployAsync_WithStagingEnvironment_UsesStagingStateFilealready uses lowercasestaging.jsonMicrosoft Reviewers: Open in CodeFlow