[release/9.2] AddAzureContainerAppEnvironment should use the environment name as a prefix#8607
Merged
eerhardt merged 5 commits intorelease/9.2from Apr 8, 2025
Merged
Conversation
b9c8585 to
36ab296
Compare
…prefix We should be prefixing the resources created via AddAzureContainerAppEnvironment with the environment name. This will allow for multiple environments to be in a single distributed application in the future. With this change, it means deploying to existing environments will duplicate resources. To solve that, add a new method WithAzdResourceNaming, which will revert the resource names back to the previous naming scheme.
36ab296 to
3e609db
Compare
mitchdenny
approved these changes
Apr 8, 2025
eerhardt
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8606 to release/9.2
/cc @eerhardt
Customer Impact
High, if you migrate from azd owned infrastructure to app host owned infrastructure, the naming convention changes and duplicate resources are deployed. To avoid that mismatch, we provide a method
WithAzdResourceNamingthat changes the naming convention to match what azd did to avoid deploying dupes.Testing
Automated and manual.
Risk
Low
Regression?
Ish