Assert 'Location' header in POST tests

Chris Martinez · Chris Martinez · commit 4a6501832af7 · 2018-12-22T15:43:37.000-08:00
diff --git a/test/Microsoft.AspNet.WebApi.Acceptance.Tests/Http/Basic/given a versioned ApiController/when using a url segment.cs b/test/Microsoft.AspNet.WebApi.Acceptance.Tests/Http/Basic/given a versioned ApiController/when using a url segment.cs
@@ -48,9 +48,10 @@ public async Task then_post_should_return_201()
             var entity = default( object );
 
             // act
-            var response = await PostAsync( "api/v1/helloworld", entity ).EnsureSuccessStatusCode();
+            var response = await PostAsync( "api/v1/helloworld", entity );
 
             // assert
+            response.StatusCode.Should().Be( Created );
             response.Headers.Location.Should().Be( new Uri( "http://localhost/api/v1/helloworld/42" ) );
         }
 
diff --git a/test/Microsoft.AspNet.WebApi.Acceptance.Tests/Http/Basic/given a versioned ApiController/when using an action.cs b/test/Microsoft.AspNet.WebApi.Acceptance.Tests/Http/Basic/given a versioned ApiController/when using an action.cs
@@ -3,6 +3,7 @@
     using FluentAssertions;
     using Microsoft.Web;
     using Microsoft.Web.Http.Basic;
+    using System;
     using System.Threading.Tasks;
     using Xunit;
     using static System.Net.HttpStatusCode;
@@ -40,6 +41,7 @@ public async Task then_post_should_return_201( string requestUrl )
 
             // assert
             response.StatusCode.Should().Be( Created );
+            response.Headers.Location.Should().Be( new Uri( "http://localhost/api/orders/42" ) );
         }
 
         [Fact]
diff --git a/test/Microsoft.AspNet.WebApi.Acceptance.Tests/Http/ByNamespace/given a versioned ApiController per namespace/when using an action.cs b/test/Microsoft.AspNet.WebApi.Acceptance.Tests/Http/ByNamespace/given a versioned ApiController per namespace/when using an action.cs
@@ -3,6 +3,7 @@
     using FluentAssertions;
     using Microsoft.Web;
     using Microsoft.Web.Http.ByNamespace;
+    using System;
     using System.Threading.Tasks;
     using Xunit;
     using static System.Net.HttpStatusCode;
@@ -37,6 +38,7 @@ public async Task then_post_should_return_201( string requestUrl )
 
             // assert
             response.StatusCode.Should().Be( Created );
+            response.Headers.Location.Should().Be( new Uri( "http://localhost/api/orders/42" ) );
         }
 
         [Fact]
diff --git a/test/Microsoft.AspNet.WebApi.Acceptance.Tests/Http/Conventions/given a versioned ApiController using conventions/when using an action.cs b/test/Microsoft.AspNet.WebApi.Acceptance.Tests/Http/Conventions/given a versioned ApiController using conventions/when using an action.cs
@@ -3,6 +3,7 @@
     using FluentAssertions;
     using Microsoft.Web;
     using Microsoft.Web.Http.Conventions;
+    using System;
     using System.Threading.Tasks;
     using Xunit;
     using static System.Net.HttpStatusCode;
@@ -40,6 +41,7 @@ public async Task then_post_should_return_201( string requestUrl )
 
             // assert
             response.StatusCode.Should().Be( Created );
+            response.Headers.Location.Should().Be( new Uri( "http://localhost/api/orders/42" ) );
         }
 
         [Fact]
diff --git a/test/Microsoft.AspNet.WebApi.Acceptance.Tests/Http/MediaTypeNegotiation/given a versioned ApiController/when using media type negotiation.cs b/test/Microsoft.AspNet.WebApi.Acceptance.Tests/Http/MediaTypeNegotiation/given a versioned ApiController/when using media type negotiation.cs
@@ -76,9 +76,10 @@ public async Task then_post_should_return_201()
             var content = new ObjectContent( entity.GetType(), entity, new JsonMediaTypeFormatter(), mediaType );
 
             // act
-            var response = await PostAsync( "api/helloworld", content ).EnsureSuccessStatusCode();
+            var response = await PostAsync( "api/helloworld", content );
 
             // assert
+            response.StatusCode.Should().Be( Created );
             response.Headers.Location.Should().Be( new Uri( "http://localhost/api/helloworld/42" ) );
         }
 
diff --git a/test/Microsoft.AspNet.WebApi.Acceptance.Tests/OData/Basic/given a versioned ODataController/when using an action.cs b/test/Microsoft.AspNet.WebApi.Acceptance.Tests/OData/Basic/given a versioned ODataController/when using an action.cs
@@ -2,6 +2,7 @@
 {
     using FluentAssertions;
     using Microsoft.AspNet.OData.Basic;
+    using System;
     using System.Threading.Tasks;
     using Xunit;
     using static System.Net.HttpStatusCode;
@@ -39,6 +40,7 @@ public async Task then_post_should_return_201( string requestUrl )
 
             // assert
             response.StatusCode.Should().Be( Created );
+            response.Headers.Location.Should().Be( new Uri( "http://localhost/api/Customers(42)" ) );
         }
 
         [Fact]
diff --git a/test/Microsoft.AspNet.WebApi.Acceptance.Tests/OData/Conventions/given a versioned ODataController using conventions/when using an action.cs b/test/Microsoft.AspNet.WebApi.Acceptance.Tests/OData/Conventions/given a versioned ODataController using conventions/when using an action.cs
@@ -3,6 +3,7 @@
     using FluentAssertions;
     using Microsoft.AspNet.OData;
     using Microsoft.AspNet.OData.Conventions;
+    using System;
     using System.Threading.Tasks;
     using Xunit;
     using static System.Net.HttpStatusCode;
@@ -41,6 +42,7 @@ public async Task then_post_should_return_201( string requestUrl )
 
             // assert
             response.StatusCode.Should().Be( Created );
+            response.Headers.Location.Should().Be( new Uri( "http://localhost/api/Customers(42)" ) );
         }
 
         [Fact]
diff --git a/test/Microsoft.AspNetCore.Mvc.Acceptance.Tests/Mvc/Basic/given a versioned Controller/when using a url segment.cs b/test/Microsoft.AspNetCore.Mvc.Acceptance.Tests/Mvc/Basic/given a versioned Controller/when using a url segment.cs
@@ -57,9 +57,10 @@ public async Task then_post_should_return_201( string version )
             var entity = default( object );
 
             // act
-            var response = await PostAsync( $"api/{version}/helloworld", entity ).EnsureSuccessStatusCode();
+            var response = await PostAsync( $"api/{version}/helloworld", entity );
 
             // assert
+            response.StatusCode.Should().Be( Created );
             response.Headers.Location.Should().Be( new Uri( $"http://localhost/api/{version}/HelloWorld/42" ) );
         }
 
diff --git a/test/Microsoft.AspNetCore.Mvc.Acceptance.Tests/Mvc/Basic/given a versioned Controller/when using an action.cs b/test/Microsoft.AspNetCore.Mvc.Acceptance.Tests/Mvc/Basic/given a versioned Controller/when using an action.cs
@@ -3,6 +3,7 @@
     using FluentAssertions;
     using Microsoft.AspNetCore.Mvc;
     using Microsoft.AspNetCore.Mvc.Basic;
+    using System;
     using System.Threading.Tasks;
     using Xunit;
     using static System.Net.HttpStatusCode;
@@ -40,6 +41,7 @@ public async Task then_post_should_return_201( string requestUrl )
 
             // assert
             response.StatusCode.Should().Be( Created );
+            response.Headers.Location.Should().Be( new Uri( "http://localhost/api/Orders/42" ) );
         }
 
         [Fact]
diff --git a/test/Microsoft.AspNetCore.Mvc.Acceptance.Tests/Mvc/ByNamespace/given a versioned Controller per namespace/when using an action.cs b/test/Microsoft.AspNetCore.Mvc.Acceptance.Tests/Mvc/ByNamespace/given a versioned Controller per namespace/when using an action.cs
@@ -3,6 +3,7 @@
     using FluentAssertions;
     using Microsoft.AspNetCore.Mvc;
     using Microsoft.AspNetCore.Mvc.ByNamespace;
+    using System;
     using System.Threading.Tasks;
     using Xunit;
     using static System.Net.HttpStatusCode;
@@ -37,6 +38,7 @@ public async Task then_post_should_return_201( string requestUrl )
 
             // assert
             response.StatusCode.Should().Be( Created );
+            response.Headers.Location.Should().Be( new Uri( "http://localhost/api/Orders/42" ) );
         }
 
         [Fact]
diff --git a/test/Microsoft.AspNetCore.Mvc.Acceptance.Tests/Mvc/Conventions/given a versioned Controller using conventions/when using an action.cs b/test/Microsoft.AspNetCore.Mvc.Acceptance.Tests/Mvc/Conventions/given a versioned Controller using conventions/when using an action.cs
@@ -3,6 +3,7 @@
     using FluentAssertions;
     using Microsoft.AspNetCore.Mvc;
     using Microsoft.AspNetCore.Mvc.Conventions;
+    using System;
     using System.Threading.Tasks;
     using Xunit;
     using static System.Net.HttpStatusCode;
@@ -40,6 +41,7 @@ public async Task then_post_should_return_201( string requestUrl )
 
             // assert
             response.StatusCode.Should().Be( Created );
+            response.Headers.Location.Should().Be( new Uri( "http://localhost/api/Orders/42" ) );
         }
 
         [Fact]
diff --git a/test/Microsoft.AspNetCore.Mvc.Acceptance.Tests/Mvc/MediaTypeNegotiation/given a versioned Controller/when using media type negotiation.cs b/test/Microsoft.AspNetCore.Mvc.Acceptance.Tests/Mvc/MediaTypeNegotiation/given a versioned Controller/when using media type negotiation.cs
@@ -80,9 +80,10 @@ public async Task then_post_should_return_201()
             content.Headers.ContentType = Parse( "application/json;v=1.0" );
 
             // act
-            var response = await PostAsync( "api/helloworld", content ).EnsureSuccessStatusCode();
+            var response = await PostAsync( "api/helloworld", content );
 
             // assert
+            response.StatusCode.Should().Be( Created );
             response.Headers.Location.Should().Be( new Uri( "http://localhost/api/HelloWorld/42" ) );
         }
 

Original file line number	Diff line number	Diff line change
`@@ -48,9 +48,10 @@ public async Task then_post_should_return_201()`
`48`	`48`	`var entity = default( object );`
`49`	`49`
`50`	`50`	`// act`
`51`		`- var response = await PostAsync( "api/v1/helloworld", entity ).EnsureSuccessStatusCode();`
	`51`	`+ var response = await PostAsync( "api/v1/helloworld", entity );`
`52`	`52`
`53`	`53`	`// assert`
	`54`	`+ response.StatusCode.Should().Be( Created );`
`54`	`55`	`response.Headers.Location.Should().Be( new Uri( "http://localhost/api/v1/helloworld/42" ) );`
`55`	`56`	`}`
`56`	`57`
Original file line number	Diff line number	Diff line change
`@@ -76,9 +76,10 @@ public async Task then_post_should_return_201()`
`76`	`76`	`var content = new ObjectContent( entity.GetType(), entity, new JsonMediaTypeFormatter(), mediaType );`
`77`	`77`
`78`	`78`	`// act`
`79`		`- var response = await PostAsync( "api/helloworld", content ).EnsureSuccessStatusCode();`
	`79`	`+ var response = await PostAsync( "api/helloworld", content );`
`80`	`80`
`81`	`81`	`// assert`
	`82`	`+ response.StatusCode.Should().Be( Created );`
`82`	`83`	`response.Headers.Location.Should().Be( new Uri( "http://localhost/api/helloworld/42" ) );`
`83`	`84`	`}`
`84`	`85`
Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`	`{`
`3`	`3`	`using FluentAssertions;`
`4`	`4`	`using Microsoft.AspNet.OData.Basic;`
	`5`	`+ using System;`
`5`	`6`	`using System.Threading.Tasks;`
`6`	`7`	`using Xunit;`
`7`	`8`	`using static System.Net.HttpStatusCode;`
`@@ -39,6 +40,7 @@ public async Task then_post_should_return_201( string requestUrl )`
`39`	`40`
`40`	`41`	`// assert`
`41`	`42`	`response.StatusCode.Should().Be( Created );`
	`43`	`+ response.Headers.Location.Should().Be( new Uri( "http://localhost/api/Customers(42)" ) );`
`42`	`44`	`}`
`43`	`45`
`44`	`46`	`[Fact]`
Original file line number	Diff line number	Diff line change
`@@ -57,9 +57,10 @@ public async Task then_post_should_return_201( string version )`
`57`	`57`	`var entity = default( object );`
`58`	`58`
`59`	`59`	`// act`
`60`		`- var response = await PostAsync( $"api/{version}/helloworld", entity ).EnsureSuccessStatusCode();`
	`60`	`+ var response = await PostAsync( $"api/{version}/helloworld", entity );`
`61`	`61`
`62`	`62`	`// assert`
	`63`	`+ response.StatusCode.Should().Be( Created );`
`63`	`64`	`response.Headers.Location.Should().Be( new Uri( $"http://localhost/api/{version}/HelloWorld/42" ) );`
`64`	`65`	`}`
`65`	`66`
Original file line number	Diff line number	Diff line change
`@@ -80,9 +80,10 @@ public async Task then_post_should_return_201()`
`80`	`80`	`content.Headers.ContentType = Parse( "application/json;v=1.0" );`
`81`	`81`
`82`	`82`	`// act`
`83`		`- var response = await PostAsync( "api/helloworld", content ).EnsureSuccessStatusCode();`
	`83`	`+ var response = await PostAsync( "api/helloworld", content );`
`84`	`84`
`85`	`85`	`// assert`
	`86`	`+ response.StatusCode.Should().Be( Created );`
`86`	`87`	`response.Headers.Location.Should().Be( new Uri( "http://localhost/api/HelloWorld/42" ) );`
`87`	`88`	`}`
`88`	`89`