Address more feedback

Author: captainsafia

src/OpenApi/sample/Sample.csproj

@@ -19,7 +19,7 @@
   </ItemGroup>
 
   <ItemGroup>
-    <ProjectReference Include="../test/Microsoft.AspNetCore.OpenApi.Tests.csproj" />
+    <Compile Include="../test/SharedTypes.cs" />
   </ItemGroup>
 
 </Project>

src/OpenApi/src/Services/OpenApiConstants.cs

@@ -9,5 +9,5 @@ internal static class OpenApiConstants
     internal const string DefaultOpenApiVersion = "1.0.0";
     internal const string DefaultOpenApiRoute = "/openapi/{documentName}.json";
     internal const string DescriptionId = "x-aspnetcore-id";
-    internal const string DefaultResponseStatusCode = "default";
+    internal const string DefaultOpenApiResponseKey = "default";
 }

src/OpenApi/src/Services/OpenApiDocumentService.cs

@@ -181,10 +181,10 @@ private static OpenApiResponses GetResponses(ApiDescription description)
             // the response for all HTTP status codes that are not explicitly defined
             // for a given operation. This is typically used to describe catch-all scenarios
             // like error responses.
-            var statusCode = responseType.IsDefaultResponse
-                ? OpenApiConstants.DefaultResponseStatusCode
+            var responseKey = responseType.IsDefaultResponse
+                ? OpenApiConstants.DefaultOpenApiResponseKey
                 : responseType.StatusCode.ToString(CultureInfo.InvariantCulture);
-            responses.Add(statusCode, GetResponse(description, responseType.StatusCode, responseType));
+            responses.Add(responseKey, GetResponse(description, responseType.StatusCode, responseType));
         }
         return responses;
     }

src/OpenApi/test/Services/OpenApiDocumentServiceTests.Responses.cs

@@ -224,9 +224,34 @@ await VerifyOpenApiDocument(builder, document =>
         {
             var operation = Assert.Single(document.Paths["/api/todos"].Operations.Values);
             var response = Assert.Single(operation.Responses);
-            Assert.Equal(Microsoft.AspNetCore.OpenApi.OpenApiConstants.DefaultResponseStatusCode, response.Key);
+            Assert.Equal(Microsoft.AspNetCore.OpenApi.OpenApiConstants.DefaultOpenApiResponseKey, response.Key);
             Assert.Empty(response.Value.Description);
             // Todo: Validate generated schema.
         });
     }
+
+    [Fact]
+    public async Task GetOpenApiResponse_SupportsGeneratingDefaultResponseWithSuccessResponse()
+    {
+        // Arrange
+        var builder = CreateBuilder();
+
+        // Act
+        builder.MapGet("/api/todos", [ProducesDefaultResponseType(typeof(Error))] () => { })
+            .WithMetadata(new ProducesResponseTypeMetadata(StatusCodes.Status200OK, typeof(Todo), ["application/json"]));
+
+        // Assert
+        await VerifyOpenApiDocument(builder, document =>
+        {
+            var operation = Assert.Single(document.Paths["/api/todos"].Operations.Values);
+            var defaultResponse = operation.Responses[Microsoft.AspNetCore.OpenApi.OpenApiConstants.DefaultOpenApiResponseKey];
+            Assert.NotNull(defaultResponse);
+            Assert.Empty(defaultResponse.Description);
+            var okResponse = operation.Responses["200"];
+            Assert.NotNull(okResponse);
+            Assert.Equal("OK", okResponse.Description);
+            Assert.Equal("application/json", Assert.Single(okResponse.Content).Key);
+            // Todo: Validate generated schema.
+        });
+    }
 }