Skip to content

Commit 21afee0

Browse files
authored
Fix race in RST_STREAM_IncompleteRequest_AdditionalWindowUpdateFrame_ConnectionAborted (#57450)
* Unquarantine RST_STREAM_IncompleteRequest_AdditionalWindowUpdateFrame_ConnectionAborted There was a race between early-sending the response headers and sending the goaway for the aborted connection. Fixes #53744 * Keep test quarantined
1 parent 81ca2a4 commit 21afee0

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2ConnectionTests.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3604,10 +3604,11 @@ public async Task RST_STREAM_IncompleteRequest_AdditionalWindowUpdateFrame_Conne
36043604
await SendDataAsync(1, new byte[1], endStream: false);
36053605
await SendRstStreamAsync(1);
36063606
await SendWindowUpdateAsync(1, 1024);
3607-
tcs.TrySetResult();
36083607

36093608
await WaitForConnectionErrorAsync<Http2ConnectionErrorException>(ignoreNonGoAwayFrames: false, expectedLastStreamId: 1,
36103609
Http2ErrorCode.STREAM_CLOSED, CoreStrings.FormatHttp2ErrorStreamAborted(Http2FrameType.WINDOW_UPDATE, 1));
3610+
3611+
tcs.TrySetResult(); // Don't let the response start until after the abort
36113612
}
36123613

36133614
[Fact]

0 commit comments

Comments
 (0)