Skip to content

Commit 26a88e0

Browse files
author
John Luo
authored
Merge pull request #30603 from dotnet-maestro-bot/merge/release/3.1-to-main
[automated] Merge branch 'release/3.1' => 'main'
2 parents fb3092b + 1ab35bc commit 26a88e0

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

Directory.Build.targets

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@
7979
<PropertyGroup>
8080
<!-- When OnlyPackPlatformSpecificPackages is set, only produce packages for projects which set RuntimeIdentifier. -->
8181
<!-- Keep this below where we set "IsPackageInThisPatch" -->
82-
<IsPackable Condition=" '$(OnlyPackPlatformSpecificPackages)' == 'true' AND '$(RuntimeIdentifier)' == '' ">false</IsPackable>
82+
<!-- Do not apply this logic to App.Ref and App.Ref.Internal, it's packability is determined by IsTargetingPackBuilding -->
83+
<IsPackable Condition=" '$(MSBuildProjectName)' != 'Microsoft.AspNetCore.App.Ref' AND '$(MSBuildProjectName)' != 'Microsoft.AspNetCore.App.Ref.Internal' AND '$(OnlyPackPlatformSpecificPackages)' == 'true' AND '$(RuntimeIdentifier)' == '' ">false</IsPackable>
8384
</PropertyGroup>
8485

8586
<PropertyGroup>

src/Installers/Windows/TargetingPack/TargetingPack.wixproj

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@
2121
<NamespaceGuid>DDBB771F-963F-47D3-8510-9ABD04DBE1D1</NamespaceGuid>
2222
<SchemaVersion>2.0</SchemaVersion>
2323
<ToolsetInstallerNuspecFile>$(RepoRoot)\src\Installers\Windows\TargetingPack\TargetingPackPackage.nuspec</ToolsetInstallerNuspecFile>
24+
<PackageVersion>$(TargetingPackVersionPrefix)</PackageVersion>
25+
<BundleVersion>$(TargetingPackVersionPrefix)</BundleVersion>
2426
</PropertyGroup>
2527

2628
<ItemGroup>
@@ -61,7 +63,9 @@
6163
<Target Name="ExtractIntermediateTargetingPack" BeforeTargets="PrepareForBuild">
6264
<PropertyGroup>
6365
<TargetingPackHarvestRoot Condition="'$(TargetingPackHarvestRoot)' == ''">$(InstallersOutputPath)</TargetingPackHarvestRoot>
64-
<IntermediateTargetingPackZip>$(TargetingPackHarvestRoot)aspnetcore-targeting-pack-$(PackageVersion).zip</IntermediateTargetingPackZip>
66+
<TargetingPackZipVersion>$(TargetingPackVersionPrefix)</TargetingPackZipVersion>
67+
<TargetingPackZipVersion Condition="'$(VersionSuffix)' != ''">$(TargetingPackZipVersion)-$(VersionSuffix)</TargetingPackZipVersion>
68+
<IntermediateTargetingPackZip>$(TargetingPackHarvestRoot)aspnetcore-targeting-pack-$(TargetingPackZipVersion).zip</IntermediateTargetingPackZip>
6569
</PropertyGroup>
6670

6771
<Unzip SourceFiles="$(IntermediateTargetingPackZip)" DestinationFolder="$(HarvestSource)" />

src/Installers/Windows/Wix.targets

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44
<!-- Actual upgrade code used in bundles to ensure upgrades withing a version band, e.g. 3.0.0.xxx -->
55
<_FileRevisionVersion>$(VersionSuffixDateStamp)</_FileRevisionVersion>
66
<_FileRevisionVersion Condition=" '$(_FileRevisionVersion)' == '' ">42424</_FileRevisionVersion>
7-
<BundleVersion>$(AspNetCoreMajorMinorVersion).$(AspNetCorePatchVersion).$(_FileRevisionVersion)</BundleVersion>
7+
<BundleVersion Condition="'$(BundleVersion)' != ''" >$(BundleVersion).$(_FileRevisionVersion)</BundleVersion>
8+
<BundleVersion Condition="'$(BundleVersion)' == ''" >$(AspNetCoreMajorMinorVersion).$(AspNetCorePatchVersion).$(_FileRevisionVersion)</BundleVersion>
89
<!-- Used for generating stable upgrade codes for bundles -->
910
<Version>$(BundleVersion)</Version>
1011

0 commit comments

Comments
 (0)