Skip to content

Commit 2cf0201

Browse files
BrennanConroyjkotalik
authored andcommitted
Update to new corefx packages (#486)
1 parent 869e3d3 commit 2cf0201

File tree

7 files changed

+16
-29
lines changed

7 files changed

+16
-29
lines changed

Directory.Build.props

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,4 @@
1818
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
1919
</PropertyGroup>
2020

21-
<ItemGroup>
22-
<!-- This is an experimental version of the compiler. See https://github.com/dotnet/csharplang/issues/666 for more details. -->
23-
<PackageReference Include="Microsoft.NETCore.Compilers" Version="$(MicrosoftNETCoreCompilersPackageVersion)" PrivateAssets="All" />
24-
</ItemGroup>
25-
2621
</Project>

build/dependencies.props

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@
2929
<MicrosoftExtensionsPlatformAbstractionsPackageVersion>1.1.0</MicrosoftExtensionsPlatformAbstractionsPackageVersion>
3030
<MicrosoftExtensionsSecurityHelperSourcesPackageVersion>2.1.0-preview1-27644</MicrosoftExtensionsSecurityHelperSourcesPackageVersion>
3131
<MicrosoftNETCoreApp20PackageVersion>2.0.0</MicrosoftNETCoreApp20PackageVersion>
32-
<MicrosoftNETCoreApp21PackageVersion>2.1.0-preview1-25915-01</MicrosoftNETCoreApp21PackageVersion>
33-
<MicrosoftNETCoreCompilersPackageVersion>2.6.0-beta2-62211-02</MicrosoftNETCoreCompilersPackageVersion>
32+
<MicrosoftNETCoreApp21PackageVersion>2.1.0-preview1-26008-01</MicrosoftNETCoreApp21PackageVersion>
3433
<MicrosoftNETTestSdkPackageVersion>15.3.0</MicrosoftNETTestSdkPackageVersion>
3534
<SystemBuffersPackageVersion>4.5.0-preview1-25914-04</SystemBuffersPackageVersion>
3635
<SystemIOPipelinesPackageVersion>0.1.0-alpha-002</SystemIOPipelinesPackageVersion>

korebuild-lock.txt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,2 @@
1-
<<<<<<< HEAD
21
version:2.1.0-preview1-15620
32
commithash:6432b49a2c00310416df39b6fe548ef4af9c6011
4-
=======
5-
version:2.1.0-preview1-15618
6-
commithash:00ce1383114015fe89b221146036e59e6bc11219
7-
>>>>>>> 0dae9f5... Update dependencies.props

src/Microsoft.AspNetCore.Server.IISIntegration/Server/IISHttpContext.cs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
using Microsoft.AspNetCore.Http;
2020
using Microsoft.AspNetCore.HttpSys.Internal;
2121
using Microsoft.AspNetCore.WebUtilities;
22-
using Microsoft.Extensions.Primitives;
2322

2423
namespace Microsoft.AspNetCore.Server.IISIntegration
2524
{
@@ -41,7 +40,7 @@ internal abstract partial class IISHttpContext : NativeRequestContext, IDisposab
4140
protected Stack<KeyValuePair<Func<object, Task>, object>> _onCompleted;
4241

4342
protected Exception _applicationException;
44-
private readonly BufferPool _bufferPool;
43+
private readonly MemoryPool _memoryPool;
4544

4645
private GCHandle _thisHandle;
4746
private MemoryHandle _inputHandle;
@@ -64,12 +63,12 @@ internal abstract partial class IISHttpContext : NativeRequestContext, IDisposab
6463
private const string NegotiateString = "Negotiate";
6564
private const string BasicString = "Basic";
6665

67-
internal unsafe IISHttpContext(BufferPool bufferPool, IntPtr pHttpContext, IISOptions options)
66+
internal unsafe IISHttpContext(MemoryPool memoryPool, IntPtr pHttpContext, IISOptions options)
6867
: base((HttpApiTypes.HTTP_REQUEST*)NativeMethods.http_get_raw_request(pHttpContext))
6968
{
7069
_thisHandle = GCHandle.Alloc(this);
7170

72-
_bufferPool = bufferPool;
71+
_memoryPool = memoryPool;
7372
_pHttpContext = pHttpContext;
7473

7574
NativeMethods.http_set_managed_context(_pHttpContext, (IntPtr)_thisHandle);
@@ -142,8 +141,8 @@ internal unsafe IISHttpContext(BufferPool bufferPool, IntPtr pHttpContext, IISOp
142141
RequestBody = new IISHttpRequestBody(this);
143142
ResponseBody = new IISHttpResponseBody(this);
144143

145-
Input = new Pipe(new PipeOptions(_bufferPool, readerScheduler: TaskRunScheduler.Default));
146-
var pipe = new Pipe(new PipeOptions(_bufferPool, readerScheduler: TaskRunScheduler.Default));
144+
Input = new Pipe(new PipeOptions(_memoryPool, readerScheduler: TaskRunScheduler.Default));
145+
var pipe = new Pipe(new PipeOptions(_memoryPool, readerScheduler: TaskRunScheduler.Default));
147146
Output = new OutputProducer(pipe);
148147
}
149148

src/Microsoft.AspNetCore.Server.IISIntegration/Server/IISHttpContextOfT.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
using System.Buffers;
66
using System.Threading.Tasks;
77
using System.Threading;
8-
using System.IO.Pipelines;
98
using Microsoft.AspNetCore.Builder;
109
using Microsoft.AspNetCore.Hosting.Server;
1110

@@ -15,8 +14,8 @@ internal class IISHttpContextOfT<TContext> : IISHttpContext
1514
{
1615
private readonly IHttpApplication<TContext> _application;
1716

18-
public IISHttpContextOfT(BufferPool bufferPool, IHttpApplication<TContext> application, IntPtr pHttpContext, IISOptions options)
19-
: base(bufferPool, pHttpContext, options)
17+
public IISHttpContextOfT(MemoryPool memoryPool, IHttpApplication<TContext> application, IntPtr pHttpContext, IISOptions options)
18+
: base(memoryPool, pHttpContext, options)
2019
{
2120
_application = application;
2221
}

src/Microsoft.AspNetCore.Server.IISIntegration/Server/IISHttpServer.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ internal class IISHttpServer : IServer
2323
private static NativeMethods.PFN_ASYNC_COMPLETION _onAsyncCompletion = OnAsyncCompletion;
2424

2525
private IISContextFactory _iisContextFactory;
26-
private readonly BufferPool _bufferPool = new MemoryPool();
26+
private readonly MemoryPool _memoryPool = new MemoryPool();
2727
private GCHandle _httpServerHandle;
2828
private readonly IApplicationLifetime _applicationLifetime;
2929
private readonly IAuthenticationSchemeProvider _authentication;
@@ -46,7 +46,7 @@ public Task StartAsync<TContext>(IHttpApplication<TContext> application, Cancell
4646
{
4747
_httpServerHandle = GCHandle.Alloc(this);
4848

49-
_iisContextFactory = new IISContextFactory<TContext>(_bufferPool, application, _options);
49+
_iisContextFactory = new IISContextFactory<TContext>(_memoryPool, application, _options);
5050

5151
// Start the server by registering the callback
5252
NativeMethods.register_callbacks(_requestHandler, _shutdownHandler, _onAsyncCompletion, (IntPtr)_httpServerHandle, (IntPtr)_httpServerHandle);
@@ -70,7 +70,7 @@ public void Dispose()
7070
_httpServerHandle.Free();
7171
}
7272

73-
_bufferPool.Dispose();
73+
_memoryPool.Dispose();
7474
}
7575

7676
private static NativeMethods.REQUEST_NOTIFICATION_STATUS HandleRequest(IntPtr pHttpContext, IntPtr pvRequestContext)
@@ -126,19 +126,19 @@ private static NativeMethods.REQUEST_NOTIFICATION_STATUS ConvertRequestCompletio
126126
private class IISContextFactory<T> : IISContextFactory
127127
{
128128
private readonly IHttpApplication<T> _application;
129-
private readonly BufferPool _bufferPool;
129+
private readonly MemoryPool _memoryPool;
130130
private readonly IISOptions _options;
131131

132-
public IISContextFactory(BufferPool bufferPool, IHttpApplication<T> application, IISOptions options)
132+
public IISContextFactory(MemoryPool memoryPool, IHttpApplication<T> application, IISOptions options)
133133
{
134134
_application = application;
135-
_bufferPool = bufferPool;
135+
_memoryPool = memoryPool;
136136
_options = options;
137137
}
138138

139139
public IISHttpContext CreateHttpContext(IntPtr pHttpContext)
140140
{
141-
return new IISHttpContextOfT<T>(_bufferPool, _application, pHttpContext, _options);
141+
return new IISHttpContextOfT<T>(_memoryPool, _application, pHttpContext, _options);
142142
}
143143
}
144144
}

test/IISIntegration.FunctionalTests/HttpsTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ private async Task HttpsHelloWorld(RuntimeFlavor runtimeFlavor, ApplicationType
9090
[Fact]
9191
public Task Https_HelloWorld_NoClientCert_CoreCLR_X64_Portable()
9292
{
93-
return HttpsHelloWorldCerts(RuntimeFlavor.CoreClr, ApplicationType.Portable , port: 44398, sendClientCert: false);
93+
return HttpsHelloWorldCerts(RuntimeFlavor.CoreClr, ApplicationType.Portable , port: 44397, sendClientCert: false);
9494
}
9595

9696
[Fact]

0 commit comments

Comments
 (0)