Add TSLint rule file and fix all violations (#1381)

Author: BrennanConroy

client-ts/FunctionalTests/package.json

@@ -10,7 +10,8 @@
   },
   "scripts": {
     "clean": "node ../node_modules/rimraf/bin.js ./wwwroot/dist",
-    "build": "npm run build:tsc && npm run build:rollup",
+    "build": "npm run build:lint && npm run build:tsc && npm run build:rollup",
+    "build:lint": "node ../node_modules/tslint/bin/tslint -c ../tslint.json -p ./tsconfig.json",
     "build:tsc": "node ../node_modules/typescript/bin/tsc --project ./tsconfig.json",
     "build:rollup": "node ../node_modules/rollup/bin/rollup -c"
   },

client-ts/FunctionalTests/ts/Common.ts

@@ -1,13 +1,13 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-import { TransportType, IHubProtocol, JsonHubProtocol } from "@aspnet/signalr"
-import { MessagePackHubProtocol } from "@aspnet/signalr-protocol-msgpack"
+import { IHubProtocol, JsonHubProtocol, TransportType } from "@aspnet/signalr";
+import { MessagePackHubProtocol } from "@aspnet/signalr-protocol-msgpack";
 
 export const ECHOENDPOINT_URL = "http://" + document.location.host + "/echo";
 
 export function getTransportTypes(): TransportType[] {
-    var transportTypes = [];
+    const transportTypes = [];
     if (typeof WebSocket !== "undefined") {
         transportTypes.push(TransportType.WebSockets);
     }
@@ -20,13 +20,13 @@ export function getTransportTypes(): TransportType[] {
 }
 
 export function eachTransport(action: (transport: TransportType) => void) {
-    getTransportTypes().forEach(function (t) {
+    getTransportTypes().forEach((t) => {
         return action(t);
     });
 }
 
 export function eachTransportAndProtocol(action: (transport: TransportType, protocol: IHubProtocol) => void) {
-    var protocols : IHubProtocol[] = [new JsonHubProtocol()];
+    const protocols: IHubProtocol[] = [new JsonHubProtocol()];
     // IE9 does not support XmlHttpRequest advanced features so disable for now
     // This can be enabled if we fix: https://github.com/aspnet/SignalR/issues/742
     if (typeof new XMLHttpRequest().responseType === "string") {
@@ -35,9 +35,9 @@ export function eachTransportAndProtocol(action: (transport: TransportType, prot
         // Everything works fine in the module
         protocols.push(new MessagePackHubProtocol());
     }
-    getTransportTypes().forEach(function (t) {
-        return protocols.forEach(function (p) {
+    getTransportTypes().forEach((t) => {
+        return protocols.forEach((p) => {
             return action(t, p);
         });
     });
-}
+}

client-ts/FunctionalTests/ts/ConnectionTests.ts

@@ -1,63 +1,63 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-import { HttpConnection, LogLevel, TransportType } from "@aspnet/signalr"
-import { eachTransport, ECHOENDPOINT_URL } from "./Common"
+import { HttpConnection, LogLevel, TransportType } from "@aspnet/signalr";
+import { eachTransport, ECHOENDPOINT_URL } from "./Common";
 
-describe('connection', function () {
-    if (typeof WebSocket !== 'undefined') {
-        it("can connect to the server without specifying transport explicitly", function (done) {
-            var message = "Hello World!";
-            var connection = new HttpConnection(ECHOENDPOINT_URL);
+describe("connection", () => {
+    if (typeof WebSocket !== "undefined") {
+        it("can connect to the server without specifying transport explicitly", (done) => {
+            const message = "Hello World!";
+            const connection = new HttpConnection(ECHOENDPOINT_URL);
 
-            var received = "";
-            connection.onreceive = function (data) {
+            let received = "";
+            connection.onreceive = (data) => {
                 received += data;
-                if (data == message) {
+                if (data === message) {
                     connection.stop();
                 }
             };
 
-            connection.onclose = function (error) {
+            connection.onclose = (error) => {
                 expect(error).toBeUndefined();
                 done();
             };
 
-            connection.start().then(function () {
+            connection.start().then(() => {
                 connection.send(message);
-            }).catch(function (e) {
+            }).catch((e) => {
                 fail();
                 done();
             });
         });
     }
 
-    eachTransport(function (transportType) {
-        it("over " + TransportType[transportType] + " can send and receive messages", function (done) {
-            var message = "Hello World!";
+    eachTransport((transportType) => {
+        it("over " + TransportType[transportType] + " can send and receive messages", (done) => {
+            const message = "Hello World!";
             // the url should be resolved relative to the document.location.host
             // and the leading '/' should be automatically added to the url
-            var connection = new HttpConnection("echo", {
+            const connection = new HttpConnection("echo", {
+                logger: LogLevel.Trace,
                 transport: transportType,
-                logger: LogLevel.Trace
             });
 
-            var received = "";
-            connection.onreceive = function (data) {
+            let received = "";
+            connection.onreceive = (data) => {
                 received += data;
-                if (data == message) {
+                if (data === message) {
                     connection.stop();
                 }
             };
 
-            connection.onclose = function (error) {
+            connection.onclose = (error) => {
                 expect(error).toBeUndefined();
                 done();
             };
 
-            connection.start().then(function () {
+            connection.start().then(() => {
                 connection.send(message);
-            }).catch(function (e) {
+            }).catch((e) => {
                 fail();
                 done();
             });