Skip to content

Commit 5810af5

Browse files
authored
Fix code-signing metadata for the SignalR java client (#6607)
1 parent 22f3166 commit 5810af5

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

eng/targets/Npm.Common.targets

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@
6969
<Exec Command="npm $(NpmTestArgs)" IgnoreStandardErrorWarningFormat="true" />
7070
</Target>
7171

72-
<Target Name="GetArtifactInfo" Condition="'$(IsPackable)' == 'true'">
72+
<Target Name="GetArtifactInfo" Condition="'$(IsPackable)' == 'true'" Returns="@(ArtifactInfo)">
7373
<ItemGroup>
7474
<ArtifactInfo Include="$(TargetPath)" >
7575
<ArtifactType>NpmPackage</ArtifactType>

src/SignalR/clients/java/signalr/signalr.javaproj

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,21 +53,20 @@
5353
<Exec Command="./gradlew $(GradleOptions) test" IgnoreStandardErrorWarningFormat="true" />
5454
</Target>
5555

56-
<Target Name="GetArtifactInfo" Condition="'$(IsPackable)' == 'true' ">
56+
<Target Name="GetArtifactInfo" Condition="'$(IsPackable)' == 'true' " Returns="@(ArtifactInfo)">
5757
<ItemGroup>
5858
<ArtifactInfo Include="$(PackageOutputPath)%(Jars.Identity)">
5959
<ArtifactType>JavaJar</ArtifactType>
6060
<Version>$(PackageVersion)</Version>
6161
<Category>ship</Category>
62+
<ShouldBeSigned>true</ShouldBeSigned>
63+
<Certificate>$(JarSigningCertName)</Certificate>
6264
</ArtifactInfo>
6365
<ArtifactInfo Include="$(PackageOutputPath)%(PomFile.Identity)">
6466
<ArtifactType>MavenPOM</ArtifactType>
6567
<Version>$(PackageVersion)</Version>
6668
<Category>ship</Category>
6769
</ArtifactInfo>
68-
69-
<FilesToSign Include="$(PackageOutputPath)%(Jars.Identity)" Certificate="$(JarSigningCertName)" />
70-
<FilesToExcludeFromSigning Include="$(PackageOutputPath)%(PomFile.Identity)" />
7170
</ItemGroup>
7271
</Target>
7372

0 commit comments

Comments
 (0)