Convert TLS connection adapter to connection middleware (#11109)

Author: jkotalik

src/Servers/Kestrel/Core/src/Adapter/Internal/AdaptedPipeline.cs

@@ -21,7 +21,7 @@ internal class AdaptedPipeline : IDuplexPipe
         public AdaptedPipeline(IDuplexPipe transport,
                                Pipe inputPipe,
                                Pipe outputPipe,
-                               IKestrelTrace log,
+                               ILogger log,
                                int minAllocBufferSize)
         {
             TransportStream = new RawStream(transport.Input, transport.Output, throwOnCancelled: true);
@@ -37,7 +37,7 @@ public AdaptedPipeline(IDuplexPipe transport,
 
         public Pipe Output { get; }
 
-        public IKestrelTrace Log { get; }
+        public ILogger Log { get; }
 
         PipeReader IDuplexPipe.Input => Input.Reader;
 

src/Servers/Kestrel/Core/src/HttpsConnectionAdapterOptions.cs

@@ -2,6 +2,7 @@
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System;
+using System.IO.Pipelines;
 using System.Net.Security;
 using System.Security.Authentication;
 using System.Security.Cryptography.X509Certificates;
@@ -96,5 +97,11 @@ public TimeSpan HandshakeTimeout
                 _handshakeTimeout = value != Timeout.InfiniteTimeSpan ? value : TimeSpan.MaxValue;
             }
         }
+
+        internal PipeScheduler Scheduler { get; set; } = PipeScheduler.ThreadPool;
+
+        internal long? MaxInputBufferSize { get; set; }
+
+        internal long? MaxOutputBufferSize { get; set; }
     }
 }

src/Servers/Kestrel/Core/src/Internal/HttpConnection.cs

@@ -215,64 +215,90 @@ private HttpConnectionContext CreateDerivedContext(IDuplexPipe transport)
 
         private void StopProcessingNextRequest()
         {
+            ProtocolSelectionState previousState;
             lock (_protocolSelectionLock)
             {
+                previousState = _protocolSelectionState;
+
                 switch (_protocolSelectionState)
                 {
                     case ProtocolSelectionState.Initializing:
-                        CloseUninitializedConnection(new ConnectionAbortedException(CoreStrings.ServerShutdownDuringConnectionInitialization));
                         _protocolSelectionState = ProtocolSelectionState.Aborted;
                         break;
                     case ProtocolSelectionState.Selected:
-                        _requestProcessor.StopProcessingNextRequest();
-                        break;
                     case ProtocolSelectionState.Aborted:
                         break;
                 }
             }
+
+            switch (previousState)
+            {
+                case ProtocolSelectionState.Initializing:
+                    CloseUninitializedConnection(new ConnectionAbortedException(CoreStrings.ServerShutdownDuringConnectionInitialization));
+                    break;
+                case ProtocolSelectionState.Selected:
+                    _requestProcessor.StopProcessingNextRequest();
+                    break;
+                case ProtocolSelectionState.Aborted:
+                    break;
+            }
         }
 
         private void OnInputOrOutputCompleted()
         {
+            ProtocolSelectionState previousState;
             lock (_protocolSelectionLock)
             {
+                previousState = _protocolSelectionState;
+
                 switch (_protocolSelectionState)
                 {
                     case ProtocolSelectionState.Initializing:
-                        // OnReader/WriterCompleted callbacks are not wired until after leaving the Initializing state.
-                        Debug.Assert(false);
-
-                        CloseUninitializedConnection(new ConnectionAbortedException("HttpConnection.OnInputOrOutputCompleted() called while in the ProtocolSelectionState.Initializing state!?"));
                         _protocolSelectionState = ProtocolSelectionState.Aborted;
                         break;
                     case ProtocolSelectionState.Selected:
-                        _requestProcessor.OnInputOrOutputCompleted();
-                        break;
                     case ProtocolSelectionState.Aborted:
                         break;
                 }
+            }
+
+            switch (previousState)
+            {
+                case ProtocolSelectionState.Initializing:
+                    // ConnectionClosed callback is not wired up until after leaving the Initializing state.
+                    Debug.Assert(false);
 
+                    CloseUninitializedConnection(new ConnectionAbortedException("HttpConnection.OnInputOrOutputCompleted() called while in the ProtocolSelectionState.Initializing state!?"));
+                    break;
+                case ProtocolSelectionState.Selected:
+                    _requestProcessor.OnInputOrOutputCompleted();
+                    break;
+                case ProtocolSelectionState.Aborted:
+                    break;
             }
         }
 
         private void Abort(ConnectionAbortedException ex)
         {
+            ProtocolSelectionState previousState;
+
             lock (_protocolSelectionLock)
             {
-                switch (_protocolSelectionState)
-                {
-                    case ProtocolSelectionState.Initializing:
-                        CloseUninitializedConnection(ex);
-                        break;
-                    case ProtocolSelectionState.Selected:
-                        _requestProcessor.Abort(ex);
-                        break;
-                    case ProtocolSelectionState.Aborted:
-                        break;
-                }
-
+                previousState = _protocolSelectionState;
                 _protocolSelectionState = ProtocolSelectionState.Aborted;
             }
+
+            switch (previousState)
+            {
+                case ProtocolSelectionState.Initializing:
+                    CloseUninitializedConnection(ex);
+                    break;
+                case ProtocolSelectionState.Selected:
+                    _requestProcessor.Abort(ex);
+                    break;
+                case ProtocolSelectionState.Aborted:
+                    break;
+            }
         }
 
         private async Task<Stream> ApplyConnectionAdaptersAsync(RawStream stream)
@@ -365,6 +391,12 @@ private void Tick()
         private void CloseUninitializedConnection(ConnectionAbortedException abortReason)
         {
             _context.ConnectionContext.Abort(abortReason);
+
+            if (_context.ConnectionAdapters.Count > 0)
+            {
+                _adaptedTransport.Input.Complete();
+                _adaptedTransport.Output.Complete();
+            }
         }
 
         public void OnTimeout(TimeoutReason reason)