Log StartupTimeoutLimit failure to response (#10661)

Author: jkotalik

src/Servers/IIS/AspNetCoreModuleV2/InProcessRequestHandler/dllmain.cpp

@@ -122,10 +122,13 @@ CreateApplication(
 
         std::unique_ptr<IN_PROCESS_APPLICATION, IAPPLICATION_DELETER> inProcessApplication;
 
-        // TODO not sure how easy it will be to untangle errors here
-        // ErrorContext errorContext;
+        ErrorContext errorContext;
+        errorContext.statusCode = 500;
+        errorContext.subStatusCode = 30;
+        errorContext.generalErrorType = "ANCM In-Process Start Failure";
+        errorContext.errorReason = "<ul><li>The application failed to start</li><li>The application started but then stopped</li><li>The application started but threw an exception during startup</li></ul>";
 
-        if (!FAILED_LOG(hr = IN_PROCESS_APPLICATION::Start(*pServer, pSite, *pHttpApplication, pParameters, nParameters, inProcessApplication)))
+        if (!FAILED_LOG(hr = IN_PROCESS_APPLICATION::Start(*pServer, pSite, *pHttpApplication, pParameters, nParameters, inProcessApplication, errorContext)))
         {
             *ppApplication = inProcessApplication.release();
         }
@@ -138,19 +141,19 @@ CreateApplication(
                 g_errorPageContent :
                 FILE_UTILITY::GetHtml(g_hServerModule,
                     IN_PROCESS_RH_STATIC_HTML,
-                    500i16,
-                    30i16,
-                    "ANCM In-Process Start Failure",
-                    "<ul><li>The application failed to start</li><li>The application started but then stopped</li><li>The application started but threw an exception during startup</li></ul>",
+                    errorContext.statusCode,
+                    errorContext.subStatusCode,
+                    errorContext.generalErrorType,
+                    errorContext.errorReason,
                     "");
 
             auto pErrorApplication = std::make_unique<StartupExceptionApplication>(*pServer,
                 *pHttpApplication,
                 options->QueryDisableStartUpErrorPage(),
                 hr,
                 content,
-                500i16,
-                30i16,
+                errorContext.statusCode,
+                errorContext.subStatusCode,
                 "Internal Server Error");
 
             RETURN_IF_FAILED(pErrorApplication->StartMonitoringAppOffline());

src/Servers/IIS/AspNetCoreModuleV2/InProcessRequestHandler/inprocessapplication.cpp

@@ -130,7 +130,7 @@ IN_PROCESS_APPLICATION::SetCallbackHandles(
 }
 
 HRESULT
-IN_PROCESS_APPLICATION::LoadManagedApplication()
+IN_PROCESS_APPLICATION::LoadManagedApplication(ErrorContext& errorContext)
 {
     THROW_LAST_ERROR_IF_NULL(m_pInitializeEvent = CreateEvent(
         nullptr,  // default security attributes
@@ -157,11 +157,17 @@ IN_PROCESS_APPLICATION::LoadManagedApplication()
 
     // Wait for shutdown request
     const auto waitResult = WaitForMultipleObjects(2, waitHandles, FALSE, m_pConfig->QueryStartupTimeLimitInMS());
+
     THROW_LAST_ERROR_IF(waitResult == WAIT_FAILED);
 
     if (waitResult == WAIT_TIMEOUT)
     {
         // If server wasn't initialized in time shut application down without waiting for CLR thread to exit
+        errorContext.statusCode = 500;
+        errorContext.subStatusCode = 37;
+        errorContext.generalErrorType = "ANCM Failed to Start Within Startup Time Limit";
+        errorContext.errorReason = format("ANCM failed to start after %d milliseconds", m_pConfig->QueryStartupTimeLimitInMS());
+
         m_waitForShutdown = false;
         StopClr();
         throw InvalidOperationException(format(L"Managed server didn't initialize after %u ms.", m_pConfig->QueryStartupTimeLimitInMS()));
@@ -380,15 +386,16 @@ HRESULT IN_PROCESS_APPLICATION::Start(
     IHttpApplication& pHttpApplication,
     APPLICATION_PARAMETER* pParameters,
     DWORD nParameters,
-    std::unique_ptr<IN_PROCESS_APPLICATION, IAPPLICATION_DELETER>& application)
+    std::unique_ptr<IN_PROCESS_APPLICATION, IAPPLICATION_DELETER>& application,
+    ErrorContext& errorContext)
 {
     try
     {
         std::unique_ptr<InProcessOptions> options;
         THROW_IF_FAILED(InProcessOptions::Create(pServer, pSite, pHttpApplication, options));
         application = std::unique_ptr<IN_PROCESS_APPLICATION, IAPPLICATION_DELETER>(
             new IN_PROCESS_APPLICATION(pServer, pHttpApplication, std::move(options), pParameters, nParameters));
-        THROW_IF_FAILED(application->LoadManagedApplication());
+        THROW_IF_FAILED(application->LoadManagedApplication(errorContext));
         return S_OK;
     }
     catch (InvalidOperationException& ex)

src/Servers/IIS/AspNetCoreModuleV2/InProcessRequestHandler/inprocessapplication.h

@@ -58,7 +58,7 @@ class IN_PROCESS_APPLICATION : public InProcessApplicationBase
     ExecuteApplication();
 
     HRESULT
-    LoadManagedApplication();
+    LoadManagedApplication(ErrorContext& errorContext);
 
     void
     QueueStop();
@@ -115,7 +115,8 @@ class IN_PROCESS_APPLICATION : public InProcessApplicationBase
         IHttpApplication& pHttpApplication,
         APPLICATION_PARAMETER* pParameters,
         DWORD nParameters,
-        std::unique_ptr<IN_PROCESS_APPLICATION, IAPPLICATION_DELETER>& application);
+        std::unique_ptr<IN_PROCESS_APPLICATION, IAPPLICATION_DELETER>& application,
+        ErrorContext& errorContext);
 
 private:
     struct ExecuteClrContext: std::enable_shared_from_this<ExecuteClrContext>

src/Servers/IIS/IIS/test/Common.FunctionalTests/Inprocess/StartupTests.cs

@@ -416,7 +416,6 @@ public async Task RemoveInProcessReference_FailedToFindRequestHandler()
         }
 
         [ConditionalFact]
-        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1772", FlakyOn.All)]
         public async Task StartupTimeoutIsApplied()
         {
             // From what I can tell, this failure is due to ungraceful shutdown.
@@ -434,11 +433,17 @@ public async Task StartupTimeoutIsApplied()
                 var response = await deploymentResult.HttpClient.GetAsync("/");
                 Assert.Equal(HttpStatusCode.InternalServerError, response.StatusCode);
 
-                StopServer();
+                StopServer(gracefulShutdown: false);
 
                 EventLogHelpers.VerifyEventLogEvents(deploymentResult,
                     EventLogHelpers.InProcessFailedToStart(deploymentResult, "Managed server didn't initialize after 1000 ms.")
                     );
+
+                if (DeployerSelector.HasNewHandler)
+                {
+                    var responseContent = await response.Content.ReadAsStringAsync();
+                    Assert.Contains("ANCM Failed to Start Within Startup Time Limit", responseContent);
+                }
             }
         }