Skip to content

Commit 8109690

Browse files
authored
Replaced Span<T>.Fill(0) with Span<T>.Clear() (#20023)
1 parent 9cab3e2 commit 8109690

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

src/Components/Server/src/BlazorPack/SequenceOfT.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -443,7 +443,7 @@ private void ClearReferences(int startIndex, int length)
443443
// If we store references, clear them to allow the objects to be GC'd.
444444
if (!IsValueTypeElement)
445445
{
446-
this.AvailableMemory.Span.Slice(startIndex, length).Fill(default);
446+
this.AvailableMemory.Span.Slice(startIndex, length).Clear();
447447
}
448448
}
449449
}

src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2TestBase.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -545,7 +545,7 @@ protected Task SendHeadersWithPaddingAsync(int streamId, IEnumerable<KeyValuePai
545545

546546
HPackHeaderWriter.BeginEncodeHeaders(_hpackEncoder, GetHeadersEnumerator(headers), payload, out var length);
547547
var padding = buffer.Slice(extendedHeaderLength + length, padLength);
548-
padding.Fill(0);
548+
padding.Clear();
549549

550550
frame.PayloadLength = extendedHeaderLength + length + padLength;
551551

src/Shared/Http2cat/Http2Utilities.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ public Task SendHeadersWithPaddingAsync(int streamId, IEnumerable<KeyValuePair<s
343343

344344
HPackHeaderWriter.BeginEncodeHeaders(GetHeadersEnumerator(headers), payload, out var length);
345345
var padding = buffer.Slice(extendedHeaderLength + length, padLength);
346-
padding.Fill(0);
346+
padding.Clear();
347347

348348
frame.PayloadLength = extendedHeaderLength + length + padLength;
349349

@@ -431,7 +431,7 @@ public Task SendHeadersWithPaddingAndPriorityAsync(int streamId, IEnumerable<Key
431431

432432
HPackHeaderWriter.BeginEncodeHeaders(GetHeadersEnumerator(headers), payload, out var length);
433433
var padding = buffer.Slice(extendedHeaderLength + length, padLength);
434-
padding.Fill(0);
434+
padding.Clear();
435435

436436
frame.PayloadLength = extendedHeaderLength + length + padLength;
437437

src/Shared/HttpSys/RequestProcessing/NativeRequestContext.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ internal NativeRequestContext(SafeNativeOverlapped nativeOverlapped, MemoryPool<
5353
// No size limit
5454
_backingBuffer = MemoryPool<byte>.Shared.Rent(newSize);
5555
}
56-
_backingBuffer.Memory.Span.Fill(0);// Zero the buffer
56+
_backingBuffer.Memory.Span.Clear();
5757
_memoryHandle = _backingBuffer.Memory.Pin();
5858
_nativeRequest = (HttpApiTypes.HTTP_REQUEST*)((long)_memoryHandle.Pointer + _bufferAlignment);
5959

0 commit comments

Comments
 (0)