Update Microsoft.Net.Compilers.Toolset (#31403)

BrennanConroy · web-flow · commit 85082798976f · 2021-03-31T09:38:45.000-07:00
diff --git a/eng/Versions.props b/eng/Versions.props
@@ -158,7 +158,7 @@
   </PropertyGroup>
   <PropertyGroup Label="Manual">
     <!-- Packages from dotnet/roslyn -->
-    <MicrosoftNetCompilersToolsetVersion>3.8.0-5.20519.18</MicrosoftNetCompilersToolsetVersion>
+    <MicrosoftNetCompilersToolsetVersion>3.10.0-1.final</MicrosoftNetCompilersToolsetVersion>
     <!-- DiagnosticAdapter package pinned temporarily until migrated/deprecated -->
     <MicrosoftExtensionsDiagnosticAdapterVersion>5.0.0-preview.4.20180.4</MicrosoftExtensionsDiagnosticAdapterVersion>
     <!-- Build tool dependencies -->
diff --git a/src/Components/Components/src/PublicAPI.Unshipped.txt b/src/Components/Components/src/PublicAPI.Unshipped.txt
@@ -1,6 +1,7 @@
 #nullable enable
 *REMOVED*static Microsoft.AspNetCore.Components.ParameterView.FromDictionary(System.Collections.Generic.IDictionary<string!, object!>! parameters) -> Microsoft.AspNetCore.Components.ParameterView
 *REMOVED*virtual Microsoft.AspNetCore.Components.RenderTree.Renderer.DispatchEventAsync(ulong eventHandlerId, Microsoft.AspNetCore.Components.RenderTree.EventFieldInfo! fieldInfo, System.EventArgs! eventArgs) -> System.Threading.Tasks.Task!
+*REMOVED*readonly Microsoft.AspNetCore.Components.RenderTree.RenderTreeEdit.RemovedAttributeName -> string!
 Microsoft.AspNetCore.Components.ComponentApplicationState
 Microsoft.AspNetCore.Components.ComponentApplicationState.OnPersisting -> Microsoft.AspNetCore.Components.ComponentApplicationState.OnPersistingCallback!
 Microsoft.AspNetCore.Components.ComponentApplicationState.OnPersistingCallback
@@ -35,4 +36,4 @@ Microsoft.AspNetCore.Components.RenderTree.Renderer.GetEventArgsType(ulong event
 override Microsoft.AspNetCore.Components.LayoutComponentBase.SetParametersAsync(Microsoft.AspNetCore.Components.ParameterView parameters) -> System.Threading.Tasks.Task!
 static Microsoft.AspNetCore.Components.ParameterView.FromDictionary(System.Collections.Generic.IDictionary<string!, object?>! parameters) -> Microsoft.AspNetCore.Components.ParameterView
 virtual Microsoft.AspNetCore.Components.RenderTree.Renderer.DispatchEventAsync(ulong eventHandlerId, Microsoft.AspNetCore.Components.RenderTree.EventFieldInfo? fieldInfo, System.EventArgs! eventArgs) -> System.Threading.Tasks.Task!
-*REMOVED*readonly Microsoft.AspNetCore.Components.RenderTree.RenderTreeEdit.RemovedAttributeName -> string
+readonly Microsoft.AspNetCore.Components.RenderTree.RenderTreeEdit.RemovedAttributeName -> string?
diff --git a/src/Components/Components/src/RenderTree/RenderTreeEdit.cs b/src/Components/Components/src/RenderTree/RenderTreeEdit.cs
@@ -48,7 +48,7 @@ public readonly struct RenderTreeEdit
         /// If the <see cref="Type"/> value is <see cref="RenderTreeEditType.RemoveAttribute"/>,
         /// gets the name of the attribute that is being removed.
         /// </summary>
-        [FieldOffset(16)] public readonly string RemovedAttributeName;
+        [FieldOffset(16)] public readonly string? RemovedAttributeName;
 
         private RenderTreeEdit(RenderTreeEditType type) : this()
         {
diff --git a/src/Components/Ignitor/src/ElementHive.cs b/src/Components/Ignitor/src/ElementHive.cs
@@ -149,7 +149,7 @@ private void ApplyEdits(RenderBatch batch, ContainerNode parent, int childIndex,
                             var node = parent.Children[childIndexAtCurrentDepth + siblingIndex];
                             if (node is ElementNode element)
                             {
-                                var attributeName = edit.RemovedAttributeName;
+                                var attributeName = edit.RemovedAttributeName!;
 
                                 // First try to remove any special property we use for this attribute
                                 if (!TryApplySpecialProperty(batch, element, attributeName, default))
diff --git a/src/DataProtection/DataProtection/src/KeyManagement/IKeyManager.cs b/src/DataProtection/DataProtection/src/KeyManagement/IKeyManager.cs
@@ -59,7 +59,7 @@ public interface IKeyManager
         /// This method will not mutate existing IKey instances. After calling this method,
         /// all existing IKey instances should be discarded, and GetAllKeys should be called again.
         /// </remarks>
-        void RevokeKey(Guid keyId, string reason = null);
+        void RevokeKey(Guid keyId, string? reason = null);
 
         /// <summary>
         /// Revokes all keys created before a specified date and persists the revocation to the
@@ -72,6 +72,6 @@ public interface IKeyManager
         /// This method will not mutate existing IKey instances. After calling this method,
         /// all existing IKey instances should be discarded, and GetAllKeys should be called again.
         /// </remarks>
-        void RevokeAllKeys(DateTimeOffset revocationDate, string reason = null);
+        void RevokeAllKeys(DateTimeOffset revocationDate, string? reason = null);
     }
 }
diff --git a/src/DataProtection/DataProtection/src/Managed/ManagedAuthenticatedEncryptor.cs b/src/DataProtection/DataProtection/src/Managed/ManagedAuthenticatedEncryptor.cs
@@ -229,12 +229,12 @@ public byte[] Decrypt(ArraySegment<byte> protectedPayload, ArraySegment<byte> ad
                                 macOffset = eofOffset - _validationAlgorithmDigestLengthInBytes;
                             }
 
-                            correctHash = hashAlgorithm.ComputeHash(protectedPayload.Array, ivOffset, macOffset - ivOffset);
+                            correctHash = hashAlgorithm.ComputeHash(protectedPayload.Array!, ivOffset, macOffset - ivOffset);
                         }
 
                         // Step 4: Validate the MAC provided as part of the payload.
 
-                        if (!CryptoUtil.TimeConstantBuffersAreEqual(correctHash, 0, correctHash.Length, protectedPayload.Array, macOffset, eofOffset - macOffset))
+                        if (!CryptoUtil.TimeConstantBuffersAreEqual(correctHash, 0, correctHash.Length, protectedPayload.Array!, macOffset, eofOffset - macOffset))
                         {
                             throw Error.CryptCommon_PayloadInvalid(); // integrity check failure
                         }
@@ -247,7 +247,7 @@ public byte[] Decrypt(ArraySegment<byte> protectedPayload, ArraySegment<byte> ad
                             var outputStream = new MemoryStream();
                             using (var cryptoStream = new CryptoStream(outputStream, cryptoTransform, CryptoStreamMode.Write))
                             {
-                                cryptoStream.Write(protectedPayload.Array, ciphertextOffset, macOffset - ciphertextOffset);
+                                cryptoStream.Write(protectedPayload.Array!, ciphertextOffset, macOffset - ciphertextOffset);
                                 cryptoStream.FlushFinalBlock();
 
                                 // At this point, outputStream := { plaintext }, and we're done!
@@ -349,7 +349,7 @@ public byte[] Encrypt(ArraySegment<byte> plaintext, ArraySegment<byte> additiona
                                 var mac = validationAlgorithm.ComputeHash(underlyingBuffer, KEY_MODIFIER_SIZE_IN_BYTES, checked((int)outputStream.Length - KEY_MODIFIER_SIZE_IN_BYTES));
                                 outputStream.Write(mac, 0, mac.Length);
 
-                                // At this point, outputStream := { keyModifier || IV || ciphertext || MAC(IV || ciphertext) } 
+                                // At this point, outputStream := { keyModifier || IV || ciphertext || MAC(IV || ciphertext) }
                                 // And we're done!
                                 return outputStream.ToArray();
                             }
diff --git a/src/DataProtection/DataProtection/src/PublicAPI.Unshipped.txt b/src/DataProtection/DataProtection/src/PublicAPI.Unshipped.txt
@@ -28,6 +28,8 @@
 *REMOVED*static Microsoft.AspNetCore.DataProtection.Repositories.FileSystemXmlRepository.DefaultKeyStorageDirectory.get -> System.IO.DirectoryInfo!
 *REMOVED*static Microsoft.AspNetCore.DataProtection.Repositories.RegistryXmlRepository.DefaultRegistryKey.get -> Microsoft.Win32.RegistryKey!
 *REMOVED*virtual Microsoft.AspNetCore.DataProtection.XmlEncryption.CertificateResolver.ResolveCertificate(string! thumbprint) -> System.Security.Cryptography.X509Certificates.X509Certificate2!
+*REMOVED*Microsoft.AspNetCore.DataProtection.KeyManagement.IKeyManager.RevokeAllKeys(System.DateTimeOffset revocationDate, string! reason = null) -> void
+*REMOVED*Microsoft.AspNetCore.DataProtection.KeyManagement.IKeyManager.RevokeKey(System.Guid keyId, string! reason = null) -> void
 Microsoft.AspNetCore.DataProtection.AuthenticatedEncryption.AuthenticatedEncryptorFactory.CreateEncryptorInstance(Microsoft.AspNetCore.DataProtection.KeyManagement.IKey! key) -> Microsoft.AspNetCore.DataProtection.AuthenticatedEncryption.IAuthenticatedEncryptor?
 Microsoft.AspNetCore.DataProtection.AuthenticatedEncryption.CngCbcAuthenticatedEncryptorFactory.CreateEncryptorInstance(Microsoft.AspNetCore.DataProtection.KeyManagement.IKey! key) -> Microsoft.AspNetCore.DataProtection.AuthenticatedEncryption.IAuthenticatedEncryptor?
 Microsoft.AspNetCore.DataProtection.AuthenticatedEncryption.CngGcmAuthenticatedEncryptorFactory.CreateEncryptorInstance(Microsoft.AspNetCore.DataProtection.KeyManagement.IKey! key) -> Microsoft.AspNetCore.DataProtection.AuthenticatedEncryption.IAuthenticatedEncryptor?
@@ -38,6 +40,8 @@ Microsoft.AspNetCore.DataProtection.AuthenticatedEncryption.IAuthenticatedEncryp
 Microsoft.AspNetCore.DataProtection.AuthenticatedEncryption.ManagedAuthenticatedEncryptorFactory.CreateEncryptorInstance(Microsoft.AspNetCore.DataProtection.KeyManagement.IKey! key) -> Microsoft.AspNetCore.DataProtection.AuthenticatedEncryption.IAuthenticatedEncryptor?
 Microsoft.AspNetCore.DataProtection.DataProtectionOptions.ApplicationDiscriminator.get -> string?
 Microsoft.AspNetCore.DataProtection.KeyManagement.IKey.CreateEncryptor() -> Microsoft.AspNetCore.DataProtection.AuthenticatedEncryption.IAuthenticatedEncryptor?
+Microsoft.AspNetCore.DataProtection.KeyManagement.IKeyManager.RevokeAllKeys(System.DateTimeOffset revocationDate, string? reason = null) -> void
+Microsoft.AspNetCore.DataProtection.KeyManagement.IKeyManager.RevokeKey(System.Guid keyId, string? reason = null) -> void
 Microsoft.AspNetCore.DataProtection.KeyManagement.Internal.DefaultKeyResolution.DefaultKey -> Microsoft.AspNetCore.DataProtection.KeyManagement.IKey?
 Microsoft.AspNetCore.DataProtection.KeyManagement.Internal.DefaultKeyResolution.FallbackKey -> Microsoft.AspNetCore.DataProtection.KeyManagement.IKey?
 Microsoft.AspNetCore.DataProtection.KeyManagement.Internal.IInternalXmlKeyManager.RevokeSingleKey(System.Guid keyId, System.DateTimeOffset revocationDate, string? reason) -> void
@@ -56,4 +60,4 @@ Microsoft.AspNetCore.DataProtection.XmlEncryption.NullXmlEncryptor.NullXmlEncryp
 static Microsoft.AspNetCore.DataProtection.DataProtectionUtilityExtensions.GetApplicationUniqueIdentifier(this System.IServiceProvider! services) -> string?
 static Microsoft.AspNetCore.DataProtection.Repositories.FileSystemXmlRepository.DefaultKeyStorageDirectory.get -> System.IO.DirectoryInfo?
 static Microsoft.AspNetCore.DataProtection.Repositories.RegistryXmlRepository.DefaultRegistryKey.get -> Microsoft.Win32.RegistryKey?
-virtual Microsoft.AspNetCore.DataProtection.XmlEncryption.CertificateResolver.ResolveCertificate(string! thumbprint) -> System.Security.Cryptography.X509Certificates.X509Certificate2?
+virtual Microsoft.AspNetCore.DataProtection.XmlEncryption.CertificateResolver.ResolveCertificate(string! thumbprint) -> System.Security.Cryptography.X509Certificates.X509Certificate2?
diff --git a/src/Hosting/TestHost/src/TestWebSocket.cs b/src/Hosting/TestHost/src/TestWebSocket.cs
@@ -118,7 +118,7 @@ public override async Task<WebSocketReceiveResult> ReceiveAsync(ArraySegment<byt
             ThrowIfInputClosed();
             ValidateSegment(buffer);
             // TODO: InvalidOperationException if any receives are currently in progress.
-            
+
             Message? receiveMessage = _receiveMessage;
             _receiveMessage = null;
             if (receiveMessage == null)
@@ -148,7 +148,7 @@ public override async Task<WebSocketReceiveResult> ReceiveAsync(ArraySegment<byt
                 Array.Copy(receiveMessage.Buffer.Array!, receiveMessage.Buffer.Offset, buffer.Array!, buffer.Offset, count);
                 if (!endOfMessage)
                 {
-                    receiveMessage.Buffer = new ArraySegment<byte>(receiveMessage.Buffer.Array, receiveMessage.Buffer.Offset + count, receiveMessage.Buffer.Count - count);
+                    receiveMessage.Buffer = new ArraySegment<byte>(receiveMessage.Buffer.Array!, receiveMessage.Buffer.Offset + count, receiveMessage.Buffer.Count - count);
                     _receiveMessage = receiveMessage;
                 }
                 endOfMessage = endOfMessage && receiveMessage.EndOfMessage;
@@ -257,7 +257,7 @@ private class ReceiverSenderBuffer
             private bool _disposed;
             private readonly SemaphoreSlim _sem;
             private readonly Queue<Message> _messageQueue;
-            
+
             public ReceiverSenderBuffer()
             {
                 _sem = new SemaphoreSlim(0);
diff --git a/src/Http/Headers/src/BaseHeaderParser.cs b/src/Http/Headers/src/BaseHeaderParser.cs
@@ -46,8 +46,7 @@ public sealed override bool TryParseValue(StringSegment value, ref int index, ou
                 return SupportsMultipleValues;
             }
 
-            T result;
-            var length = GetParsedValueLength(value, current, out result);
+            var length = GetParsedValueLength(value, current, out var result);
 
             if (length == 0)
             {
diff --git a/src/Http/Headers/src/HttpHeaderParser.cs b/src/Http/Headers/src/HttpHeaderParser.cs
@@ -38,8 +38,7 @@ public bool SupportsMultipleValues
 
             // If a parser returns 'null', it means there was no value, but that's valid (e.g. "Accept: "). The caller
             // can ignore the value.
-            T result;
-            if (!TryParseValue(value, ref index, out result))
+            if (!TryParseValue(value, ref index, out var result))
             {
                 throw new FormatException(string.Format(CultureInfo.InvariantCulture,
                     "The header contains invalid values at index {0}: '{1}'", index, value.Value ?? "<null>"));
@@ -75,15 +74,14 @@ protected virtual bool TryParseValues(IList<string>? values, bool strict, [NotNu
 
                 while (!string.IsNullOrEmpty(value) && index < value.Length)
                 {
-                    T output;
-                    if (TryParseValue(value, ref index, out output))
+                    if (TryParseValue(value, ref index, out var output))
                     {
                         // The entry may not contain an actual value, like " , "
                         if (output != null)
                         {
                             if (results == null)
                             {
-                                results = new List<T>();    // Allocate it only when used 
+                                results = new List<T>();    // Allocate it only when used
                             }
                             results.Add(output);
                         }
@@ -133,8 +131,7 @@ protected virtual IList<T> ParseValues(IList<string>? values, bool strict)
 
                 while (!string.IsNullOrEmpty(value) && index < value.Length)
                 {
-                    T output;
-                    if (TryParseValue(value, ref index, out output))
+                    if (TryParseValue(value, ref index, out var output))
                     {
                         // The entry may not contain an actual value, like " , "
                         if (output != null)
diff --git a/src/JSInterop/Microsoft.JSInterop/src/Infrastructure/TaskGenericsUtil.cs b/src/JSInterop/Microsoft.JSInterop/src/Infrastructure/TaskGenericsUtil.cs
@@ -91,7 +91,7 @@ public void SetResult(object tcs, object? result)
                 // If necessary, attempt a cast
                 var typedResult = result is T resultT
                     ? resultT
-                    : (T)Convert.ChangeType(result, typeof(T), CultureInfo.InvariantCulture);
+                    : (T)Convert.ChangeType(result, typeof(T), CultureInfo.InvariantCulture)!;
 
                 typedTcs.SetResult(typedResult!);
             }
diff --git a/src/Mvc/test/Mvc.IntegrationTests/ValidationWithRecordIntegrationTests.cs b/src/Mvc/test/Mvc.IntegrationTests/ValidationWithRecordIntegrationTests.cs
@@ -2298,7 +2298,9 @@ public async Task Validation_InifnitelyRecursiveModel_ValidationOnTopLevelParame
 
         private static void Validation_InifnitelyRecursiveModel_ValidationOnTopLevelParameterMethod([Required] RecursiveModel model) { }
 
+#pragma warning disable CS8907 // Parameter is unread. Did you forget to use it to initialize the property with that name?
         private record RecordTypeWithValidatorsOnProperties(string Property1)
+#pragma warning restore CS8907 // Parameter is unread. Did you forget to use it to initialize the property with that name?
         {
             [Required]
             public string Property1 { get; init; }
@@ -2335,7 +2337,9 @@ public async Task Validation_ValidatorsDefinedOnRecordTypeProperties()
             Assert.Equal(expected, ex.Message);
         }
 
+#pragma warning disable CS8907 // Parameter is unread. Did you forget to use it to initialize the property with that name?
         private record RecordTypeWithValidatorsOnPropertiesAndParameters([Required] string Property1)
+#pragma warning restore CS8907 // Parameter is unread. Did you forget to use it to initialize the property with that name?
         {
             [Required]
             public string Property1 { get; init; }
@@ -2372,7 +2376,9 @@ public async Task Validation_ValidatorsDefinedOnRecordTypePropertiesAndParameter
             Assert.Equal(expected, ex.Message);
         }
 
+#pragma warning disable CS8907 // Parameter is unread. Did you forget to use it to initialize the property with that name?
         private record RecordTypeWithValidatorsOnMixOfPropertiesAndParameters([Required] string Property1, string Property2)
+#pragma warning restore CS8907 // Parameter is unread. Did you forget to use it to initialize the property with that name?
         {
             [Required]
             public string Property2 { get; init; }

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ public readonly struct RenderTreeEdit`
`48`	`48`	`/// If the <see cref="Type"/> value is <see cref="RenderTreeEditType.RemoveAttribute"/>,`
`49`	`49`	`/// gets the name of the attribute that is being removed.`
`50`	`50`	`/// </summary>`
`51`		`- [FieldOffset(16)] public readonly string RemovedAttributeName;`
	`51`	`+ [FieldOffset(16)] public readonly string? RemovedAttributeName;`
`52`	`52`
`53`	`53`	`private RenderTreeEdit(RenderTreeEditType type) : this()`
`54`	`54`	`{`
Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,7 @@ private void ApplyEdits(RenderBatch batch, ContainerNode parent, int childIndex,`
`149`	`149`	`var node = parent.Children[childIndexAtCurrentDepth + siblingIndex];`
`150`	`150`	`if (node is ElementNode element)`
`151`	`151`	`{`
`152`		`- var attributeName = edit.RemovedAttributeName;`
	`152`	`+ var attributeName = edit.RemovedAttributeName!;`
`153`	`153`
`154`	`154`	`// First try to remove any special property we use for this attribute`
`155`	`155`	`if (!TryApplySpecialProperty(batch, element, attributeName, default))`
Original file line number	Diff line number	Diff line change
`@@ -229,12 +229,12 @@ public byte[] Decrypt(ArraySegment<byte> protectedPayload, ArraySegment<byte> ad`
`229`	`229`	`macOffset = eofOffset - _validationAlgorithmDigestLengthInBytes;`
`230`	`230`	`}`
`231`	`231`
`232`		`- correctHash = hashAlgorithm.ComputeHash(protectedPayload.Array, ivOffset, macOffset - ivOffset);`
	`232`	`+ correctHash = hashAlgorithm.ComputeHash(protectedPayload.Array!, ivOffset, macOffset - ivOffset);`
`233`	`233`	`}`
`234`	`234`
`235`	`235`	`// Step 4: Validate the MAC provided as part of the payload.`
`236`	`236`
`237`		`- if (!CryptoUtil.TimeConstantBuffersAreEqual(correctHash, 0, correctHash.Length, protectedPayload.Array, macOffset, eofOffset - macOffset))`
	`237`	`+ if (!CryptoUtil.TimeConstantBuffersAreEqual(correctHash, 0, correctHash.Length, protectedPayload.Array!, macOffset, eofOffset - macOffset))`
`238`	`238`	`{`
`239`	`239`	`throw Error.CryptCommon_PayloadInvalid(); // integrity check failure`
`240`	`240`	`}`
`@@ -247,7 +247,7 @@ public byte[] Decrypt(ArraySegment<byte> protectedPayload, ArraySegment<byte> ad`
`247`	`247`	`var outputStream = new MemoryStream();`
`248`	`248`	`using (var cryptoStream = new CryptoStream(outputStream, cryptoTransform, CryptoStreamMode.Write))`
`249`	`249`	`{`
`250`		`- cryptoStream.Write(protectedPayload.Array, ciphertextOffset, macOffset - ciphertextOffset);`
	`250`	`+ cryptoStream.Write(protectedPayload.Array!, ciphertextOffset, macOffset - ciphertextOffset);`
`251`	`251`	`cryptoStream.FlushFinalBlock();`
`252`	`252`
`253`	`253`	`// At this point, outputStream := { plaintext }, and we're done!`
`@@ -349,7 +349,7 @@ public byte[] Encrypt(ArraySegment<byte> plaintext, ArraySegment<byte> additiona`
`349`	`349`	`var mac = validationAlgorithm.ComputeHash(underlyingBuffer, KEY_MODIFIER_SIZE_IN_BYTES, checked((int)outputStream.Length - KEY_MODIFIER_SIZE_IN_BYTES));`
`350`	`350`	`outputStream.Write(mac, 0, mac.Length);`
`351`	`351`
`352`		`- // At this point, outputStream := { keyModifier \|\| IV \|\| ciphertext \|\| MAC(IV \|\| ciphertext) }`
	`352`	`+ // At this point, outputStream := { keyModifier \|\| IV \|\| ciphertext \|\| MAC(IV \|\| ciphertext) }`
`353`	`353`	`// And we're done!`
`354`	`354`	`return outputStream.ToArray();`
`355`	`355`	`}`
Original file line number	Diff line number	Diff line change
`@@ -46,8 +46,7 @@ public sealed override bool TryParseValue(StringSegment value, ref int index, ou`
`46`	`46`	`return SupportsMultipleValues;`
`47`	`47`	`}`
`48`	`48`
`49`		`- T result;`
`50`		`- var length = GetParsedValueLength(value, current, out result);`
	`49`	`+ var length = GetParsedValueLength(value, current, out var result);`
`51`	`50`
`52`	`51`	`if (length == 0)`
`53`	`52`	`{`
Original file line number	Diff line number	Diff line change
`@@ -38,8 +38,7 @@ public bool SupportsMultipleValues`
`38`	`38`
`39`	`39`	`// If a parser returns 'null', it means there was no value, but that's valid (e.g. "Accept: "). The caller`
`40`	`40`	`// can ignore the value.`
`41`		`- T result;`
`42`		`- if (!TryParseValue(value, ref index, out result))`
	`41`	`+ if (!TryParseValue(value, ref index, out var result))`
`43`	`42`	`{`
`44`	`43`	`throw new FormatException(string.Format(CultureInfo.InvariantCulture,`
`45`	`44`	`"The header contains invalid values at index {0}: '{1}'", index, value.Value ?? "<null>"));`
`@@ -75,15 +74,14 @@ protected virtual bool TryParseValues(IList<string>? values, bool strict, [NotNu`
`75`	`74`
`76`	`75`	`while (!string.IsNullOrEmpty(value) && index < value.Length)`
`77`	`76`	`{`
`78`		`- T output;`
`79`		`- if (TryParseValue(value, ref index, out output))`
	`77`	`+ if (TryParseValue(value, ref index, out var output))`
`80`	`78`	`{`
`81`	`79`	`// The entry may not contain an actual value, like " , "`
`82`	`80`	`if (output != null)`
`83`	`81`	`{`
`84`	`82`	`if (results == null)`
`85`	`83`	`{`
`86`		`- results = new List<T>(); // Allocate it only when used`
	`84`	`+ results = new List<T>(); // Allocate it only when used`
`87`	`85`	`}`
`88`	`86`	`results.Add(output);`
`89`	`87`	`}`
`@@ -133,8 +131,7 @@ protected virtual IList<T> ParseValues(IList<string>? values, bool strict)`
`133`	`131`
`134`	`132`	`while (!string.IsNullOrEmpty(value) && index < value.Length)`
`135`	`133`	`{`
`136`		`- T output;`
`137`		`- if (TryParseValue(value, ref index, out output))`
	`134`	`+ if (TryParseValue(value, ref index, out var output))`
`138`	`135`	`{`
`139`	`136`	`// The entry may not contain an actual value, like " , "`
`140`	`137`	`if (output != null)`
Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ public void SetResult(object tcs, object? result)`
`91`	`91`	`// If necessary, attempt a cast`
`92`	`92`	`var typedResult = result is T resultT`
`93`	`93`	`? resultT`
`94`		`- : (T)Convert.ChangeType(result, typeof(T), CultureInfo.InvariantCulture);`
	`94`	`+ : (T)Convert.ChangeType(result, typeof(T), CultureInfo.InvariantCulture)!;`
`95`	`95`
`96`	`96`	`typedTcs.SetResult(typedResult!);`
`97`	`97`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2298,7 +2298,9 @@ public async Task Validation_InifnitelyRecursiveModel_ValidationOnTopLevelParame`
`2298`	`2298`
`2299`	`2299`	`private static void Validation_InifnitelyRecursiveModel_ValidationOnTopLevelParameterMethod([Required] RecursiveModel model) { }`
`2300`	`2300`
	`2301`	`+#pragma warning disable CS8907 // Parameter is unread. Did you forget to use it to initialize the property with that name?`
`2301`	`2302`	`private record RecordTypeWithValidatorsOnProperties(string Property1)`
	`2303`	`+#pragma warning restore CS8907 // Parameter is unread. Did you forget to use it to initialize the property with that name?`
`2302`	`2304`	`{`
`2303`	`2305`	`[Required]`
`2304`	`2306`	`public string Property1 { get; init; }`
`@@ -2335,7 +2337,9 @@ public async Task Validation_ValidatorsDefinedOnRecordTypeProperties()`
`2335`	`2337`	`Assert.Equal(expected, ex.Message);`
`2336`	`2338`	`}`
`2337`	`2339`
	`2340`	`+#pragma warning disable CS8907 // Parameter is unread. Did you forget to use it to initialize the property with that name?`
`2338`	`2341`	`private record RecordTypeWithValidatorsOnPropertiesAndParameters([Required] string Property1)`
	`2342`	`+#pragma warning restore CS8907 // Parameter is unread. Did you forget to use it to initialize the property with that name?`
`2339`	`2343`	`{`
`2340`	`2344`	`[Required]`
`2341`	`2345`	`public string Property1 { get; init; }`
`@@ -2372,7 +2376,9 @@ public async Task Validation_ValidatorsDefinedOnRecordTypePropertiesAndParameter`
`2372`	`2376`	`Assert.Equal(expected, ex.Message);`
`2373`	`2377`	`}`
`2374`	`2378`
	`2379`	`+#pragma warning disable CS8907 // Parameter is unread. Did you forget to use it to initialize the property with that name?`
`2375`	`2380`	`private record RecordTypeWithValidatorsOnMixOfPropertiesAndParameters([Required] string Property1, string Property2)`
	`2381`	`+#pragma warning restore CS8907 // Parameter is unread. Did you forget to use it to initialize the property with that name?`
`2376`	`2382`	`{`
`2377`	`2383`	`[Required]`
`2378`	`2384`	`public string Property2 { get; init; }`