Skip to content

Commit 9c29067

Browse files
authored
Unquarantine tests / skip BlazorTemplateTests
1 parent 76c3bec commit 9c29067

File tree

7 files changed

+7
-5
lines changed

7 files changed

+7
-5
lines changed

src/Middleware/Diagnostics/test/FunctionalTests/Diagnostics.FunctionalTests.csproj

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55
<SignAssembly>false</SignAssembly>
66
<AssemblyName>Diagnostics.FunctionalTests</AssemblyName>
77
<TestDependsOnMssql>true</TestDependsOnMssql>
8+
9+
<!-- https://github.com/dotnet/aspnetcore/issues/38819 LocalDb sometimes hangs on win11 helix queue -->
10+
<BuildHelixPayload>false</BuildHelixPayload>
811
</PropertyGroup>
912

1013
<ItemGroup>

src/Middleware/HttpLogging/test/FileLoggerProcessorTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,6 @@ public async Task RollsTextFilesBasedOnDate()
115115
}
116116
}
117117

118-
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/34284")]
119118
[Fact]
120119
public async Task RollsTextFilesBasedOnSize()
121120
{

src/ProjectTemplates/BlazorTemplates.Tests/BlazorTemplates.Tests.csproj

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@
99
<BaseOutputPath />
1010
<OutputPath />
1111

12+
<!-- https://github.com/dotnet/aspnetcore/issues/38818 -->
13+
<BuildHelixPayload>false</BuildHelixPayload>
14+
1215
<!-- Properties that affect test runs -->
1316
<!-- TestTemplateCreationFolder is the folder where the templates will be created. Will point out to $(OutputDir)$(TestTemplateCreationFolder) -->
1417
<TestTemplateCreationFolder>TestTemplates\</TestTemplateCreationFolder>

src/ProjectTemplates/test/BlazorServerTemplateTest.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ public BlazorServerTemplateTest(ProjectFactoryFixture projectFactory)
3838
[InlineData("SingleOrg", null)]
3939
[InlineData("SingleOrg", new string[] { "--called-api-url \"https://graph.microsoft.com\"", "--called-api-scopes user.readwrite" })]
4040
[InlineData("SingleOrg", new string[] { "--calls-graph" })]
41-
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/30882")]
4241
public Task BlazorServerTemplate_IdentityWeb_BuildAndPublish(string auth, string[] args)
4342
=> CreateBuildPublishAsync("blazorserveridweb" + Guid.NewGuid().ToString().Substring(0, 10).ToLowerInvariant(), auth, args);
4443

src/ProjectTemplates/test/RazorPagesTemplateTest.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,6 @@ public async Task RazorPagesTemplate_IndividualAuth(bool useLocalDB)
232232

233233
[ConditionalTheory]
234234
[InlineData("SingleOrg", new string[] { "--calls-graph" })]
235-
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/31729")]
236235
public Task RazorPagesTemplate_IdentityWeb_BuildsAndPublishes_WithSingleOrg(string auth, string[] args) => BuildAndPublishRazorPagesTemplate(auth: auth, args: args);
237236

238237
private async Task<Project> BuildAndPublishRazorPagesTemplate(string auth, string[] args)

src/Servers/Kestrel/test/FunctionalTests/MaxRequestBufferSizeTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ from ssl in sslValues
115115
}
116116
[Theory]
117117
[MemberData(nameof(LargeUploadData))]
118-
[QuarantinedTest("This is inherently flaky and should never be unquarantined.")]
118+
// This is inherently flaky and is relying on helix retry to pass consistently
119119
public async Task LargeUpload(long? maxRequestBufferSize, bool connectionAdapter, bool expectPause)
120120
{
121121
// Parameters

src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2ConnectionTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,6 @@ public ResponseTrailersWrapper(IHeaderDictionary headers)
235235
}
236236

237237
[Fact]
238-
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/37930")]
239238
public async Task ResponseTrailers_MultipleStreams_Reset()
240239
{
241240
IEnumerable<KeyValuePair<string, string>> requestHeaders = new[]

0 commit comments

Comments
 (0)