Skip to content

Commit 9f56862

Browse files
author
John Luo
authored
Build aspnetcore for win-arm64 (#19317)
* Build for win-arm64 * Missed file * Disable Selenium tests on arm64 * Include installers in the uploaded artifacts
1 parent 08faf42 commit 9f56862

File tree

6 files changed

+39
-3
lines changed

6 files changed

+39
-3
lines changed

.azure/pipelines/ci.yml

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -254,6 +254,38 @@ stages:
254254
- name: Windows_arm_Packages
255255
path: artifacts/packages/
256256

257+
# Build Windows ARM64
258+
- template: jobs/default-build.yml
259+
parameters:
260+
codeSign: true
261+
jobName: Windows_64_build
262+
jobDisplayName: "Build: Windows ARM64"
263+
agentOs: Windows
264+
buildArgs:
265+
-arch arm64
266+
-sign
267+
-pack
268+
-noBuildNodeJS
269+
-noBuildJava
270+
/bl:artifacts/log/build.win-arm64.binlog
271+
/p:DotNetSignType=$(_SignType)
272+
/p:OnlyPackPlatformSpecificPackages=true
273+
/p:AssetManifestFileName=aspnetcore-win-arm64.xml
274+
$(_BuildArgs)
275+
$(_PublishArgs)
276+
$(_InternalRuntimeDownloadArgs)
277+
installNodeJs: false
278+
installJdk: false
279+
artifacts:
280+
- name: Windows_arm64_Logs
281+
path: artifacts/log/
282+
publishOnError: true
283+
includeForks: true
284+
- name: Windows_arm64_Packages
285+
path: artifacts/packages/
286+
- name: Windows_arm64_Installers
287+
path: artifacts/installers/
288+
257289
# Build MacOS
258290
- template: jobs/default-build.yml
259291
parameters:

Directory.Build.props

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@
123123
win-x64;
124124
win-x86;
125125
win-arm;
126+
win-arm64;
126127
osx-x64;
127128
linux-musl-x64;
128129
linux-musl-arm64;

build.ps1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ param(
118118
[ValidateSet('Debug', 'Release')]
119119
$Configuration,
120120

121-
[ValidateSet('x64', 'x86', 'arm')]
121+
[ValidateSet('x64', 'x86', 'arm', 'arm64')]
122122
$Architecture = 'x64',
123123

124124
# A list of projects which should be built.
@@ -157,7 +157,7 @@ param(
157157

158158
# Other lifecycle targets
159159
[switch]$Help, # Show help
160-
160+
161161
# Optional arguments that enable downloading an internal
162162
# runtime or runtime from a non-default location
163163
[string]$DotNetRuntimeSourceFeed,

eng/Dependencies.props

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ and are generated based on the last package release.
9494
<LatestPackageReference Include="microsoft.netcore.app.runtime.win-x64" Version="$(MicrosoftNETCoreAppRuntimeVersion)" />
9595
<LatestPackageReference Include="microsoft.netcore.app.runtime.win-x86" Version="$(MicrosoftNETCoreAppRuntimeVersion)" />
9696
<LatestPackageReference Include="microsoft.netcore.app.runtime.win-arm" Version="$(MicrosoftNETCoreAppRuntimeVersion)" />
97+
<LatestPackageReference Include="microsoft.netcore.app.runtime.win-arm64" Version="$(MicrosoftNETCoreAppRuntimeVersion)" />
9798
<LatestPackageReference Include="microsoft.netcore.app.runtime.osx-x64" Version="$(MicrosoftNETCoreAppRuntimeVersion)" />
9899
<LatestPackageReference Include="microsoft.netcore.app.runtime.linux-x64" Version="$(MicrosoftNETCoreAppRuntimeVersion)" />
99100
<LatestPackageReference Include="microsoft.netcore.app.runtime.linux-arm" Version="$(MicrosoftNETCoreAppRuntimeVersion)" />

eng/Signing.props

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,11 @@
9393
<_DotNetFilesToExclude Include="$(BaseRedistNetCorePath)win-x64\shared\Microsoft.NETCore.App\**\*.dll" CertificateName="None" />
9494
<_DotNetFilesToExclude Include="$(BaseRedistNetCorePath)win-x86\shared\Microsoft.NETCore.App\**\*.dll" CertificateName="None" />
9595
<_DotNetFilesToExclude Include="$(BaseRedistNetCorePath)win-arm\shared\Microsoft.NETCore.App\**\*.dll" CertificateName="None" />
96+
<_DotNetFilesToExclude Include="$(BaseRedistNetCorePath)win-arm64\shared\Microsoft.NETCore.App\**\*.dll" CertificateName="None" />
9697
<_DotNetFilesToExclude Include="$(BaseRedistNetCorePath)win-x64\host\**\*.dll" CertificateName="None" />
9798
<_DotNetFilesToExclude Include="$(BaseRedistNetCorePath)win-x86\host\**\*.dll" CertificateName="None" />
9899
<_DotNetFilesToExclude Include="$(BaseRedistNetCorePath)win-arm\host\**\*.dll" CertificateName="None" />
100+
<_DotNetFilesToExclude Include="$(BaseRedistNetCorePath)win-arm64\host\**\*.dll" CertificateName="None" />
99101
<_DotNetFilesToExclude Include="$(RedistNetCorePath)dotnet.exe" CertificateName="None" />
100102
<FileSignInfo Include="@(_DotNetFilesToExclude->'%(FileName)%(Extension)'->Distinct())" CertificateName="None" />
101103

src/Shared/E2ETesting/E2ETesting.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<DefaultItemExcludes>$(DefaultItemExcludes);node_modules\**</DefaultItemExcludes>
55
<SeleniumScreenShotsFolderPath>$([MSBuild]::NormalizeDirectory('$(ArtifactsTestResultsDir)','$(MSBuildProjectName)'))</SeleniumScreenShotsFolderPath>
66
<SeleniumProcessTrackingFolder Condition="'$(SeleniumProcessTrackingFolder)' == ''">$([MSBuild]::EnsureTrailingSlash('$(RepoRoot)'))artifacts\tmp\selenium\</SeleniumProcessTrackingFolder>
7-
<SeleniumE2ETestsSupported Condition="'$(SeleniumE2ETestsSupported)' == '' and '$(TargetArchitecture)' != 'arm' and '$(OS)' == 'Windows_NT'">true</SeleniumE2ETestsSupported>
7+
<SeleniumE2ETestsSupported Condition="'$(SeleniumE2ETestsSupported)' == '' and '$(TargetArchitecture)' != 'arm' and '$(TargetArchitecture)' != 'arm64' and '$(OS)' == 'Windows_NT'">true</SeleniumE2ETestsSupported>
88

99
<!-- Config that limits driver to chrome-->
1010
<SeleniumConfigPath>$([MSBuild]::NormalizePath($(MSBuildThisFileDirectory)selenium-config.json))</SeleniumConfigPath>

0 commit comments

Comments
 (0)