Improvements to MVC EventData typess

Improvments to names
- Using EventData suffix
- More clarity for events assocated with filters

Fixes: #12263

We have to report the BeforeActionMethod using its old signature because
it's used by Intellitrace. I added a new pair of events with a better
name to use with strong types since there's no practical way to update
the old ones.

Author: rynowak

src/Mvc/Mvc.Core/ref/Microsoft.AspNetCore.Mvc.Core.netcoreapp3.0.cs

@@ -419,7 +419,7 @@ static async Task Logged(ControllerActionInvoker invoker)
                 IActionResult result = null;
                 try
                 {
-                    diagnosticListener.BeforeActionMethod(
+                    diagnosticListener.BeforeControllerActionMethod(
                         controllerContext,
                         arguments,
                         controller);
@@ -440,7 +440,7 @@ static async Task Logged(ControllerActionInvoker invoker)
                 }
                 finally
                 {
-                    diagnosticListener.AfterActionMethod(
+                    diagnosticListener.AfterControllerActionMethod(
                         controllerContext,
                         arguments,
                         controllerContext,

src/Mvc/Mvc.Core/src/Diagnostics/MvcDiagnostics.cs

@@ -23,21 +23,21 @@ public partial interface IRazorCompiledItemProvider
 }
 namespace Microsoft.AspNetCore.Mvc.Diagnostics
 {
-    public sealed partial class AfterViewPage : Microsoft.AspNetCore.Mvc.Diagnostics.EventData
+    public sealed partial class AfterViewPageEventData : Microsoft.AspNetCore.Mvc.Diagnostics.EventData
     {
         public const string EventName = "Microsoft.AspNetCore.Mvc.Razor.AfterViewPage";
-        public AfterViewPage(Microsoft.AspNetCore.Mvc.Razor.IRazorPage page, Microsoft.AspNetCore.Mvc.Rendering.ViewContext viewContext, Microsoft.AspNetCore.Mvc.Abstractions.ActionDescriptor actionDescriptor, Microsoft.AspNetCore.Http.HttpContext httpContext) { }
+        public AfterViewPageEventData(Microsoft.AspNetCore.Mvc.Razor.IRazorPage page, Microsoft.AspNetCore.Mvc.Rendering.ViewContext viewContext, Microsoft.AspNetCore.Mvc.Abstractions.ActionDescriptor actionDescriptor, Microsoft.AspNetCore.Http.HttpContext httpContext) { }
         public Microsoft.AspNetCore.Mvc.Abstractions.ActionDescriptor ActionDescriptor { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } }
         protected override int Count { get { throw null; } }
         public Microsoft.AspNetCore.Http.HttpContext HttpContext { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } }
         protected override System.Collections.Generic.KeyValuePair<string, object> this[int index] { get { throw null; } }
         public Microsoft.AspNetCore.Mvc.Razor.IRazorPage Page { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } }
         public Microsoft.AspNetCore.Mvc.Rendering.ViewContext ViewContext { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } }
     }
-    public sealed partial class BeforeViewPage : Microsoft.AspNetCore.Mvc.Diagnostics.EventData
+    public sealed partial class BeforeViewPageEventData : Microsoft.AspNetCore.Mvc.Diagnostics.EventData
     {
         public const string EventName = "Microsoft.AspNetCore.Mvc.Razor.BeforeViewPage";
-        public BeforeViewPage(Microsoft.AspNetCore.Mvc.Razor.IRazorPage page, Microsoft.AspNetCore.Mvc.Rendering.ViewContext viewContext, Microsoft.AspNetCore.Mvc.Abstractions.ActionDescriptor actionDescriptor, Microsoft.AspNetCore.Http.HttpContext httpContext) { }
+        public BeforeViewPageEventData(Microsoft.AspNetCore.Mvc.Razor.IRazorPage page, Microsoft.AspNetCore.Mvc.Rendering.ViewContext viewContext, Microsoft.AspNetCore.Mvc.Abstractions.ActionDescriptor actionDescriptor, Microsoft.AspNetCore.Http.HttpContext httpContext) { }
         public Microsoft.AspNetCore.Mvc.Abstractions.ActionDescriptor ActionDescriptor { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } }
         protected override int Count { get { throw null; } }
         public Microsoft.AspNetCore.Http.HttpContext HttpContext { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } }

src/Mvc/Mvc.Core/src/Infrastructure/ControllerActionInvoker.cs

@@ -10,13 +10,13 @@
 
 namespace Microsoft.AspNetCore.Mvc.Diagnostics
 {
-    public sealed class BeforeViewPage : EventData
+    public sealed class BeforeViewPageEventData : EventData
     {
         public const string EventName = EventNamespace + 
             "Razor." +
-            nameof(BeforeViewPage);
+            "BeforeViewPage";
 
-        public BeforeViewPage(IRazorPage page, ViewContext viewContext, ActionDescriptor actionDescriptor, HttpContext httpContext)
+        public BeforeViewPageEventData(IRazorPage page, ViewContext viewContext, ActionDescriptor actionDescriptor, HttpContext httpContext)
         {
             Page = page;
             ViewContext = viewContext;
@@ -41,13 +41,13 @@ public BeforeViewPage(IRazorPage page, ViewContext viewContext, ActionDescriptor
         };
     }
 
-    public sealed class AfterViewPage : EventData
+    public sealed class AfterViewPageEventData : EventData
     {
         public const string EventName = EventNamespace +
             "Razor." +
-            nameof(AfterViewPage);
+            "AfterViewPage";
 
-        public AfterViewPage(IRazorPage page, ViewContext viewContext, ActionDescriptor actionDescriptor, HttpContext httpContext)
+        public AfterViewPageEventData(IRazorPage page, ViewContext viewContext, ActionDescriptor actionDescriptor, HttpContext httpContext)
         {
             Page = page;
             ViewContext = viewContext;

src/Mvc/Mvc.Core/src/MvcCoreDiagnosticListenerExtensions.cs

@@ -27,11 +27,11 @@ private static void BeforeViewPageImpl(
             IRazorPage page,
             ViewContext viewContext)
         {
-            if (diagnosticListener.IsEnabled(Diagnostics.BeforeViewPage.EventName))
+            if (diagnosticListener.IsEnabled(Diagnostics.BeforeViewPageEventData.EventName))
             {
                 diagnosticListener.Write(
-                    Diagnostics.BeforeViewPage.EventName,
-                    new BeforeViewPage(
+                    Diagnostics.BeforeViewPageEventData.EventName,
+                    new BeforeViewPageEventData(
                         page,
                         viewContext,
                         viewContext.ActionDescriptor,
@@ -57,11 +57,11 @@ private static void AfterViewPageImpl(
             IRazorPage page,
             ViewContext viewContext)
         {
-            if (diagnosticListener.IsEnabled(Diagnostics.AfterViewPage.EventName))
+            if (diagnosticListener.IsEnabled(Diagnostics.AfterViewPageEventData.EventName))
             {
                 diagnosticListener.Write(
-                    Diagnostics.AfterViewPage.EventName,
-                    new AfterViewPage(
+                    Diagnostics.AfterViewPageEventData.EventName,
+                    new AfterViewPageEventData(
                         page,
                         viewContext,
                         viewContext.ActionDescriptor,