Use non-returning throw methods (#11782)

Author: benaadams

src/Servers/Kestrel/Core/src/Internal/Http/Http1OutputProducer.cs

@@ -722,10 +722,16 @@ private void ThrowIfSuffixSent()
         {
             if (_writeStreamSuffixCalled)
             {
-                throw new InvalidOperationException("Writing is not allowed after writer was completed.");
+                ThrowSuffixSent();
             }
         }
 
+        [StackTraceHidden]
+        private static void ThrowSuffixSent()
+        {
+            throw new InvalidOperationException("Writing is not allowed after writer was completed.");
+        }
+
         /// <summary>
         /// Holds a byte[] from the pool and a size value. Basically a Memory but guaranteed to be backed by an ArrayPool byte[], so that we know we can return it.
         /// </summary>

src/Servers/Kestrel/Core/src/Internal/Http/HttpProtocol.cs

@@ -1442,7 +1442,7 @@ public Task CompleteAsync(Exception exception = null)
                     // so it can be observed by BodyWriter.Complete(). If this isn't possible because an
                     // async OnStarting callback hadn't yet run, it's OK, since the Exception will be observed with
                     // the call to _bodyControl.StopAsync() in ProcessRequests().
-                    throw lengthException;
+                    ThrowException(lengthException);
                 }
 
                 return ProduceEnd();
@@ -1459,13 +1459,19 @@ private async Task CompleteAsyncAwaited(Task onStartingTask)
             {
                 if (!VerifyResponseContentLength(out var lengthException))
                 {
-                    throw lengthException;
+                    ThrowException(lengthException);
                 }
 
                 await ProduceEnd();
             }
         }
 
+        [StackTraceHidden]
+        private static void ThrowException(Exception exception)
+        {
+            throw exception;
+        }
+
         public ValueTask<FlushResult> WritePipeAsync(ReadOnlyMemory<byte> data, CancellationToken cancellationToken)
         {
             // For the first write, ensure headers are flushed if WriteDataAsync isn't called.

src/Servers/Kestrel/Core/src/Internal/Http2/Http2OutputProducer.cs

@@ -437,10 +437,16 @@ private void ThrowIfSuffixSent()
         {
             if (_suffixSent)
             {
-                throw new InvalidOperationException("Writing is not allowed after writer was completed.");
+                ThrowSuffixSent();
             }
         }
 
+        [StackTraceHidden]
+        private static void ThrowSuffixSent()
+        {
+            throw new InvalidOperationException("Writing is not allowed after writer was completed.");
+        }
+
         private static Pipe CreateDataPipe(MemoryPool<byte> pool)
             => new Pipe(new PipeOptions
             (