fix PR nits from #48450

Author: mgravell

src/Caching/StackExchangeRedis/src/Microsoft.Extensions.Caching.StackExchangeRedis.csproj

@@ -16,16 +16,20 @@
     <Reference Include="Microsoft.AspNetCore.OutputCaching" Condition="'$(TargetFramework)' != '$(DefaultNetFxTargetFramework)' and '$(TargetFramework)' != 'netstandard2.0'" />
     <Reference Include="Microsoft.Extensions.Options" />
     <Reference Include="StackExchange.Redis" />
-    <InternalsVisibleTo Include="Microsoft.Extensions.Caching.StackExchangeRedis.Tests"/>
+  </ItemGroup>
+
+  <ItemGroup>
+    <InternalsVisibleTo Include="Microsoft.Extensions.Caching.StackExchangeRedis.Tests" />
   </ItemGroup>
 
   <ItemGroup>
     <Compile Include="$(SharedSourceRoot)ThrowHelpers\ArgumentNullThrowHelper.cs" LinkBase="Shared" />
     <Compile Include="$(SharedSourceRoot)ThrowHelpers\ObjectDisposedThrowHelper.cs" LinkBase="Shared" />
     <Compile Include="$(SharedSourceRoot)CallerArgument\CallerArgumentExpressionAttribute.cs" LinkBase="Shared" />
+  </ItemGroup>
 
+  <ItemGroup>
     <AdditionalFiles Include="PublicAPI/$(TargetFramework)/PublicAPI.Shipped.txt" />
     <AdditionalFiles Include="PublicAPI/$(TargetFramework)/PublicAPI.Unshipped.txt" />
   </ItemGroup>
-
 </Project>

src/Caching/StackExchangeRedis/src/RedisOutputCacheStore.cs

@@ -114,14 +114,14 @@ private async Task RunGarbageCollectionLoopAsync()
                 catch (Exception ex)
                 {
                     // this sweep failed; log it
-                    _logger.LogDebug(ex, "Transient error occurred executing redis output-cache GC loop");
+                    _logger.LogWarning(ex, "Transient error occurred executing redis output-cache GC loop");
                 }
             }
         }
         catch (Exception ex)
         {
             // the entire loop is dead
-            _logger.LogDebug(ex, "Fatal error occurred executing redis output-cache GC loop");
+            _logger.LogError(ex, "Fatal error occurred executing redis output-cache GC loop");
         }
     }
 

src/Caching/StackExchangeRedis/src/StackExchangeRedisCacheServiceCollectionExtensions.cs

@@ -51,6 +51,8 @@ public static IServiceCollection AddStackExchangeRedisOutputCache(this IServiceC
 
         services.Configure(setupAction);
         // replace here (Add vs TryAdd) is intentional and part of test conditions
+        // long-form name qualification is because of the #if conditional; we'd need a matchin #if around
+        // a using directive, which is messy
         services.AddSingleton<AspNetCore.OutputCaching.IOutputCacheStore, RedisOutputCacheStoreImpl>();
 
         return services;

src/Middleware/OutputCaching/src/IOutputCacheBufferStore.cs

@@ -0,0 +1,33 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+using System.Buffers;
+using System.IO.Pipelines;
+
+namespace Microsoft.AspNetCore.OutputCaching;
+
+/// <summary>
+/// Represents a store for cached responses that uses a <see cref="IBufferWriter{byte}"/> as the target.
+/// </summary>
+public interface IOutputCacheBufferStore : IOutputCacheStore
+{
+    /// <summary>
+    /// Gets the cached response for the given key, if it exists.
+    /// If no cached response exists for the given key, <c>null</c> is returned.
+    /// </summary>
+    /// <param name="key">The cache key to look up.</param>
+    /// <param name="destination">The location to which the value should be written.</param>
+    /// <param name="cancellationToken">Indicates that the operation should be cancelled.</param>
+    /// <returns><c>True</c> if the response cache entry if it exists; otherwise <c>False</c>.</returns>
+    ValueTask<bool> TryGetAsync(string key, PipeWriter destination, CancellationToken cancellationToken);
+
+    /// <summary>
+    /// Stores the given response in the response cache.
+    /// </summary>
+    /// <param name="key">The cache key to store the response under.</param>
+    /// <param name="value">The response cache entry to store; this value is only defined for the duration of the method, and should not be stored without making a copy.</param>
+    /// <param name="tags">The tags associated with the cache entry to store.</param>
+    /// <param name="validFor">The amount of time the entry will be kept in the cache before expiring, relative to now.</param>
+    /// <param name="cancellationToken">Indicates that the operation should be cancelled.</param>
+    ValueTask SetAsync(string key, ReadOnlySequence<byte> value, ReadOnlyMemory<string> tags, TimeSpan validFor, CancellationToken cancellationToken);
+}

src/Middleware/OutputCaching/src/IOutputCacheStore.cs

@@ -1,9 +1,6 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-using System.Buffers;
-using System.IO.Pipelines;
-
 namespace Microsoft.AspNetCore.OutputCaching;
 
 /// <summary>
@@ -37,29 +34,3 @@ public interface IOutputCacheStore
     /// <param name="cancellationToken">Indicates that the operation should be cancelled.</param>
     ValueTask SetAsync(string key, byte[] value, string[]? tags, TimeSpan validFor, CancellationToken cancellationToken);
 }
-
-/// <summary>
-/// Represents a store for cached responses that uses a <see cref="IBufferWriter{byte}"/> as the target.
-/// </summary>
-public interface IOutputCacheBufferStore : IOutputCacheStore
-{
-    /// <summary>
-    /// Gets the cached response for the given key, if it exists.
-    /// If no cached response exists for the given key, <c>null</c> is returned.
-    /// </summary>
-    /// <param name="key">The cache key to look up.</param>
-    /// <param name="destination">The location to which the value should be written.</param>
-    /// <param name="cancellationToken">Indicates that the operation should be cancelled.</param>
-    /// <returns><c>True</c> if the response cache entry if it exists; otherwise <c>False</c>.</returns>
-    ValueTask<bool> TryGetAsync(string key, PipeWriter destination, CancellationToken cancellationToken);
-
-    /// <summary>
-    /// Stores the given response in the response cache.
-    /// </summary>
-    /// <param name="key">The cache key to store the response under.</param>
-    /// <param name="value">The response cache entry to store; this value is only defined for the duration of the method, and should not be stored without making a copy.</param>
-    /// <param name="tags">The tags associated with the cache entry to store.</param>
-    /// <param name="validFor">The amount of time the entry will be kept in the cache before expiring, relative to now.</param>
-    /// <param name="cancellationToken">Indicates that the operation should be cancelled.</param>
-    ValueTask SetAsync(string key, ReadOnlySequence<byte> value, ReadOnlyMemory<string> tags, TimeSpan validFor, CancellationToken cancellationToken);
-}