fix

Author: BrennanConroy

src/SignalR/clients/cpp/src/signalrclient/hub_connection_impl.cpp

@@ -109,7 +109,7 @@ namespace signalr
         m_handshakeTask = pplx::task_completion_event<void>();
         m_handshakeReceived = false;
         std::weak_ptr<hub_connection_impl> weak_connection = shared_from_this();
-        return m_connection->start([weak_connection, callback](std::exception_ptr start_exception)
+        m_connection->start([weak_connection, callback](std::exception_ptr start_exception)
             {
                 auto connection = weak_connection.lock();
                 if (!connection)

src/SignalR/clients/cpp/src/signalrclient/websocket_transport.cpp

@@ -148,12 +148,10 @@ namespace signalr
         _ASSERTE(uri.scheme() == _XPLATSTR("ws") || uri.scheme() == _XPLATSTR("wss"));
 
         {
-            std::unique_lock<std::mutex> stop_lock(m_start_stop_lock);
+            std::lock_guard<std::mutex> stop_lock(m_start_stop_lock);
 
             if (!m_receive_loop_cts.get_token().is_canceled())
             {
-                // just in case the user tries to start again in the callback on error
-                stop_lock.unlock();
                 callback(std::make_exception_ptr(signalr_exception("transport already connected")));
                 return;
             }