Skip to content

Commit d9521ac

Browse files
Don't exclude System.IO.Pipelines from TargetingPack version check (#39302)
Co-authored-by: Will Godbe <[email protected]>
1 parent 9fb2d4f commit d9521ac

File tree

1 file changed

+9
-14
lines changed

1 file changed

+9
-14
lines changed

src/Framework/test/TargetingPackTests.cs

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -109,22 +109,17 @@ public void RefAssemblyReferencesHaveExpectedAssemblyVersions()
109109

110110
Assert.All(dlls, path =>
111111
{
112-
// Skip netstandard2.0 System.IO.Pipelines assembly. References have old versions.
113-
var filename = Path.GetFileName(path);
114-
if (!string.Equals("System.IO.Pipelines.dll", filename, StringComparison.OrdinalIgnoreCase))
115-
{
116-
using var fileStream = File.OpenRead(path);
117-
using var peReader = new PEReader(fileStream, PEStreamOptions.Default);
118-
var reader = peReader.GetMetadataReader(MetadataReaderOptions.Default);
112+
using var fileStream = File.OpenRead(path);
113+
using var peReader = new PEReader(fileStream, PEStreamOptions.Default);
114+
var reader = peReader.GetMetadataReader(MetadataReaderOptions.Default);
119115

120-
Assert.All(reader.AssemblyReferences, handle =>
121-
{
122-
var reference = reader.GetAssemblyReference(handle);
123-
var result = 0 == reference.Version.Revision;
116+
Assert.All(reader.AssemblyReferences, handle =>
117+
{
118+
var reference = reader.GetAssemblyReference(handle);
119+
var result = (0 == reference.Version.Revision && 0 == reference.Version.Build);
124120

125-
Assert.True(result, $"In {filename}, {reference.GetAssemblyName()} has unexpected version {reference.Version}.");
126-
});
127-
}
121+
Assert.True(result, $"In {Path.GetFileName(path)}, {reference.GetAssemblyName()} has unexpected version {reference.Version}.");
122+
});
128123
});
129124
}
130125

0 commit comments

Comments
 (0)