Update exception handling condition in WsFederationHandler (#24886)

John Luo · web-flow · commit eb1d6aec16ab · 2020-08-13T22:48:04.000Z
Fixes
diff --git a/src/Security/Authentication/WsFederation/src/WsFederationHandler.cs b/src/Security/Authentication/WsFederation/src/WsFederationHandler.cs
@@ -295,7 +295,7 @@ protected override async Task<HandleRequestResult> HandleRemoteAuthenticateAsync
                 Logger.ExceptionProcessingMessage(exception);
 
                 // Refresh the configuration for exceptions that may be caused by key rollovers. The user can also request a refresh in the notification.
-                if (Options.RefreshOnIssuerKeyNotFound && exception.GetType().Equals(typeof(SecurityTokenSignatureKeyNotFoundException)))
+                if (Options.RefreshOnIssuerKeyNotFound && exception is SecurityTokenSignatureKeyNotFoundException)
                 {
                     Options.ConfigurationManager.RequestRefresh();
                 }

Original file line number	Diff line number	Diff line change
`@@ -295,7 +295,7 @@ protected override async Task<HandleRequestResult> HandleRemoteAuthenticateAsync`
`295`	`295`	`Logger.ExceptionProcessingMessage(exception);`
`296`	`296`
`297`	`297`	`// Refresh the configuration for exceptions that may be caused by key rollovers. The user can also request a refresh in the notification.`
`298`		`- if (Options.RefreshOnIssuerKeyNotFound && exception.GetType().Equals(typeof(SecurityTokenSignatureKeyNotFoundException)))`
	`298`	`+ if (Options.RefreshOnIssuerKeyNotFound && exception is SecurityTokenSignatureKeyNotFoundException)`
`299`	`299`	`{`
`300`	`300`	`Options.ConfigurationManager.RequestRefresh();`
`301`	`301`	`}`