[RDG] Account of parameter name in signature comparison (#50064)

* [RDG] Account of parameter name in signature comparison

* Update src/Http/Http.Extensions/test/RequestDelegateGenerator/CompileTimeCreationTests.cs

Co-authored-by: Brennan <[email protected]>

---------

Co-authored-by: Brennan <[email protected]>

Author: captainsafia

src/Http/Http.Extensions/gen/StaticRouteHandlerModel/EndpointParameter.cs

@@ -617,7 +617,11 @@ obj is EndpointParameter other &&
 
     public bool SignatureEquals(object obj) =>
         obj is EndpointParameter other &&
-        SymbolEqualityComparer.IncludeNullability.Equals(other.Type, Type);
+        SymbolEqualityComparer.IncludeNullability.Equals(other.Type, Type) &&
+        // The name of the parameter matters when we are querying for a specific parameter using
+        // an indexer, like `context.Request.RouteValues["id"]` or `context.Request.Query["id"]`
+        // and when generating log messages for required bodies or services.
+        other.SymbolName == SymbolName;
 
     public override int GetHashCode()
     {

src/Http/Http.Extensions/test/RequestDelegateGenerator/Baselines/MapAction_ExplicitBodyParam_ComplexReturn_Snapshot.generated.txt

@@ -162,7 +162,7 @@ namespace Microsoft.AspNetCore.Http.Generated
                 createRequestDelegate);
         }
 
-        [InterceptsLocation(@"TestMapActions.cs", 27, 5)]
+        [InterceptsLocation(@"TestMapActions.cs", 26, 5)]
         internal static RouteHandlerBuilder MapPost1(
             this IEndpointRouteBuilder endpoints,
             [StringSyntax("Route")] string pattern,