Feedback from SocketOutput port (#1502)

- Fix naming convention in LibuvAwaitable
- Remove case statement in SocketOutput

Author: davidfowl

src/Microsoft.AspNetCore.Server.Kestrel/Internal/Http/SocketOutput.cs

@@ -105,15 +105,10 @@ public async Task WriteAsync(
 
         public void End(ProduceEndType endType)
         {
-            switch (endType)
+            if (endType == ProduceEndType.SocketShutdown)
             {
-                case ProduceEndType.SocketShutdown:
-                    // Graceful shutdown
-                    _pipe.Reader.CancelPendingRead();
-                    break;
-                case ProduceEndType.SocketDisconnect:
-                    // Not graceful
-                    break;
+                // Graceful shutdown
+                _pipe.Reader.CancelPendingRead();
             }
 
             lock (_contextLock)

src/Microsoft.AspNetCore.Server.Kestrel/Internal/Infrastructure/LibuvAwaitable.cs

@@ -12,28 +12,28 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Infrastructure
 {
     public class LibuvAwaitable<TRequest> : ICriticalNotifyCompletion where TRequest : UvRequest
     {
-        private readonly static Action CALLBACK_RAN = () => { };
+        private readonly static Action _callbackCompleted = () => { };
 
         private Action _callback;
 
         private Exception _exception;
 
         private int _status;
 
-        public static Action<TRequest, int, Exception, object> Callback = (req, status, error, state) =>
+        public static readonly Action<TRequest, int, Exception, object> Callback = (req, status, error, state) =>
         {
             var awaitable = (LibuvAwaitable<TRequest>)state;
 
             awaitable._exception = error;
             awaitable._status = status;
 
-            var continuation = Interlocked.Exchange(ref awaitable._callback, CALLBACK_RAN);
+            var continuation = Interlocked.Exchange(ref awaitable._callback, _callbackCompleted);
 
             continuation?.Invoke();
         };
 
         public LibuvAwaitable<TRequest> GetAwaiter() => this;
-        public bool IsCompleted => _callback == CALLBACK_RAN;
+        public bool IsCompleted => _callback == _callbackCompleted;
 
         public UvWriteResult GetResult()
         {
@@ -50,8 +50,8 @@ public UvWriteResult GetResult()
 
         public void OnCompleted(Action continuation)
         {
-            if (_callback == CALLBACK_RAN ||
-                Interlocked.CompareExchange(ref _callback, continuation, null) == CALLBACK_RAN)
+            if (_callback == _callbackCompleted ||
+                Interlocked.CompareExchange(ref _callback, continuation, null) == _callbackCompleted)
             {
                 Task.Run(continuation);
             }
@@ -65,8 +65,8 @@ public void UnsafeOnCompleted(Action continuation)
 
     public struct UvWriteResult
     {
-        public int Status;
-        public Exception Error;
+        public int Status { get; }
+        public Exception Error { get; }
 
         public UvWriteResult(int status, Exception error)
         {