Skip to content

Components shouldn't be building any java/node dependencies when build.cmd doesn't require java/node #10504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jkotalik opened this issue May 22, 2019 · 1 comment
Closed

Components shouldn't be building any java/node dependencies when build.cmd doesn't require java/node #10504

jkotalik opened this issue May 22, 2019 · 1 comment
Assignees
@JunTaoLuo
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Comments

@jkotalik
Copy link
Contributor

Repro steps:

  1. build.cmd from repo root
  2. Java is a requirement in Components that isn't ignored, which makes it build, even though build.cmd doesn't build java.
@natemcmaster natemcmaster transferred this issue from another repository May 23, 2019
@natemcmaster natemcmaster added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 23, 2019
@natemcmaster
Copy link
Contributor

This currently surfaces like this:


Build FAILED.

D:\code\AspNetCore\src\Shared\E2ETesting\E2ETesting.targets(41,5): error MSB3073: The command "java -version" exited with code 9009. [D:\code\AspNetCore\src\Components\test\E2ETest\Microsoft.AspNetCore.Components.E2ETests.csproj]

    0 Warning(s)
    2 Error(s)

@JunTaoLuo JunTaoLuo mentioned this issue Jun 9, 2019
Merged
@JunTaoLuo JunTaoLuo mentioned this issue Jun 20, 2019
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JunTaoLuo JunTaoLuo

Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JunTaoLuo @natemcmaster @jkotalik