Skip to content

Templates aren't C# 8.0 nullability compliant by default #10921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
NTaylorMullen opened this issue Jun 5, 2019 · 2 comments
Closed

Templates aren't C# 8.0 nullability compliant by default #10921

NTaylorMullen opened this issue Jun 5, 2019 · 2 comments
Assignees
@DamianEdwards
Labels
affected-all This issue impacts all the customers area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-templates severity-minor This label is used by an internal tool
Milestone
Backlog

Comments

@NTaylorMullen
Copy link

Not sure if this is something we want to do but figured i'd file an issue anyhow. Basically our templates aren't nullability enforcement compliant. For instance RequestId:

image
@NTaylorMullen NTaylorMullen added enhancement This issue represents an ask for new feature or an enhancement to an existing one area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Jun 5, 2019
@NTaylorMullen NTaylorMullen mentioned this issue Jun 5, 2019
Closed
@mkArtakMSFT mkArtakMSFT modified the milestones: Backlog, 3.1.0 Jun 12, 2019
@mkArtakMSFT mkArtakMSFT mentioned this issue Jun 19, 2019
Closed
@NTaylorMullen NTaylorMullen mentioned this issue Aug 21, 2019
Closed
@NTaylorMullen
Copy link
Author

Just for context Blazor templates have a bit more violations: #13072 (comment)

@mkArtakMSFT mkArtakMSFT modified the milestones: 3.1.0, 5.0.0-preview1 Aug 27, 2019
@pranavkm pranavkm added affected-all This issue impacts all the customers severity-minor This label is used by an internal tool and removed cost: S labels Nov 6, 2020
@captainsafia captainsafia mentioned this issue May 17, 2021
Closed
@DamianEdwards DamianEdwards mentioned this issue Jun 30, 2021
Closed
5 tasks
@DamianEdwards DamianEdwards self-assigned this Jul 2, 2021
@DamianEdwards
Copy link
Member

This is covered by #33947 now

@ghost ghost locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DamianEdwards DamianEdwards

Labels
affected-all This issue impacts all the customers area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-templates severity-minor This label is used by an internal tool
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@pranavkm @DamianEdwards @NTaylorMullen @javiercn @mkArtakMSFT