Skip to content

Base64Url encoding duplicated with HttpAbstraction repository #2362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aspnet-hello opened this issue Jan 1, 2018 · 2 comments
Closed

Base64Url encoding duplicated with HttpAbstraction repository #2362

aspnet-hello opened this issue Jan 1, 2018 · 2 comments
Labels
Done This issue has been fixed task

Comments

@aspnet-hello
Copy link

From @ycrumeyrolle on Wednesday, June 7, 2017 5:42:43 AM

https://github.com/aspnet/Common/blob/dev/shared/Microsoft.Extensions.WebEncoders.Sources/WebEncoders.cs
https://github.com/aspnet/HttpAbstractions/blob/dev/src/Microsoft.AspNetCore.WebUtilities/Base64UrlTextEncoder.cs

Related #93

In addition, can we consider to optimize the encoder by avoiding to first convert to Base64 then replace to url-safe character. instead, convert directly to Base64Url, simply by changing the Base64 character map and by removing the padding?

Copied from original issue: dotnet/extensions#237
@aspnet-hello aspnet-hello added this to the 2.1.0-preview1 milestone Jan 1, 2018
@aspnet-hello aspnet-hello mentioned this issue Jan 1, 2018
Closed
@muratg muratg removed this from the 2.1.0-preview1 milestone Jan 17, 2018
@muratg muratg removed the 1 - Ready label Jan 17, 2018
@muratg
Copy link
Contributor

muratg commented Jan 17, 2018

@Tratcher thoughts?

@Tratcher
Copy link
Member

Looks like this was fixed back in aspnet/HttpAbstractions@ce68ec2#diff-835c72281a3d18a5d4075376a0bb8a8d

@Tratcher Tratcher added the Done This issue has been fixed label Jan 18, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Done This issue has been fixed task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@muratg @Tratcher @aspnet-hello