Skip to content

TypedHeader has linker unfriendly logic #24724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidfowl opened this issue Aug 9, 2020 · 4 comments
Closed

TypedHeader has linker unfriendly logic #24724

davidfowl opened this issue Aug 9, 2020 · 4 comments
Labels
affected-very-few This issue impacts very few customers area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions enhancement This issue represents an ask for new feature or an enhancement to an existing one linker-friendliness Tracking linker friendliness severity-nice-to-have This label is used by an internal tool
Milestone

Comments

@davidfowl
Copy link
Member

I'm not sure how common this logic is but it feels like we can remove it and not break anyone..

return GetListViaReflection<T>(values);

C:\dev\git\aspnetcore\src\Http\Http.Extensions\src\HeaderDictionaryTypeExtensions.cs(223,13): Trim analysis warning IL2006: Microsoft.AspNetCore.Http.HeaderDictionaryTypeExtensions.GetViaReflection<T>(String): The field 'System.Type Microsoft.AspNetCore.Http.HeaderDictionaryTypeExtensions/<>c__DisplayClass11_0`1::type' with dynamically accessed member kinds 'None' is passed into the implicit 'this' parameter of method 'System.Type.GetMethods(BindingFlags)' which requires dynamically accessed member kinds 'NonPublicMethods | PublicMethods'. To fix this add DynamicallyAccessedMembersAttribute to it and specify at least these member kinds 'NonPublicMethods | PublicMethods'. [C:\Users\davifowl\source\repos\WebApplication60\WebApplication60\WebApplication60.csproj]
@davidfowl davidfowl added the linker-friendliness Tracking linker friendliness label Aug 9, 2020
@BrennanConroy BrennanConroy added this to the Backlog milestone Aug 10, 2020
@ghost
Copy link

ghost commented Aug 10, 2020

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@jkotalik jkotalik added affected-very-few This issue impacts very few customers enhancement This issue represents an ask for new feature or an enhancement to an existing one severity-nice-to-have This label is used by an internal tool labels Nov 13, 2020 — with ASP.NET Core Issue Ranking
@ghost
Copy link

ghost commented Apr 20, 2021

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. Because it's not immediately obvious that this is a bug in our framework, we would like to keep this around to collect more feedback, which can later help us determine the impact of it. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@ghost
Copy link

ghost commented Aug 3, 2021

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@JamesNK JamesNK modified the milestones: Backlog, 7.0.0 May 16, 2022
@JamesNK
Copy link
Member

JamesNK commented May 16, 2022

Fixed via #40561

@JamesNK JamesNK closed this as completed May 16, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jun 16, 2022
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affected-very-few This issue impacts very few customers area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions enhancement This issue represents an ask for new feature or an enhancement to an existing one linker-friendliness Tracking linker friendliness severity-nice-to-have This label is used by an internal tool
Projects
None yet
Development

No branches or pull requests

7 participants