Skip to content

ILEmitTrieFactory isn't linker friendly #24725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidfowl opened this issue Aug 9, 2020 · 3 comments
Closed

ILEmitTrieFactory isn't linker friendly #24725

davidfowl opened this issue Aug 9, 2020 · 3 comments
Labels
affected-few This issue impacts only small number of customers bug This issue describes a behavior which is not expected - a bug. feature-routing linker-friendliness Tracking linker friendliness old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels severity-major This label is used by an internal tool

Comments

@davidfowl
Copy link
Member

We're doing reflection to find methods on the Unsafe class but the pattern isn't visible to the linker.

C:\dev\git\aspnetcore\src\Http\Routing\src\Matching\ILEmitTrieFactory.cs(492,17): Trim analysis warning IL2006: Microsoft.AspNetCore.Routing.Matching.ILEmitTrieFactory.Methods.Methods(): Call to 'System.Reflection.MethodInfo.MakeGenericMethod' is not recognized. [C:\Users\davifowl\source\repos\WebApplication60\WebApplication60\WebApplication60.csproj]
C:\dev\git\aspnetcore\src\Http\Routing\src\Matching\ILEmitTrieFactory.cs(505,17): Trim analysis warning IL2006: Microsoft.AspNetCore.Routing.Matching.ILEmitTrieFactory.Methods.Methods(): Call to 'System.Reflection.MethodInfo.MakeGenericMethod' is not recognized. [C:\Users\davifowl\source\repos\WebApplication60\WebApplication60\WebApplication60.csproj]
C:\dev\git\aspnetcore\src\Http\Routing\src\Matching\ILEmitTrieFactory.cs(529,17): Trim analysis warning IL2006: Microsoft.AspNetCore.Routing.Matching.ILEmitTrieFactory.Methods.Methods(): Call to 'System.Reflection.MethodInfo.MakeGenericMethod' is not recognized. [C:\Users\davifowl\source\repos\WebApplication60\WebApplication60\WebApplication60.csproj]
C:\dev\git\aspnetcore\src\Http\Routing\src\Matching\ILEmitTrieFactory.cs(543,17): Trim analysis warning IL2006: Microsoft.AspNetCore.Routing.Matching.ILEmitTrieFactory.Methods.Methods(): Call to 'System.Reflection.MethodInfo.MakeGenericMethod' is not recognized. [C:\Users\davifowl\source\repos\WebApplication60\WebApplication60\WebApplication60.csproj]
C:\dev\git\aspnetcore\src\Http\Routing\src\Matching\ILEmitTrieFactory.cs(555,17): Trim analysis warning IL2006: Microsoft.AspNetCore.Routing.Matching.ILEmitTrieFactory.Methods.Methods(): Call to 'System.Reflection.MethodInfo.MakeGenericMethod' is not recognized. [C:\Users\davifowl\source\repos\WebApplication60\WebApplication60\WebApplication60.csproj]
@davidfowl davidfowl added the linker-friendliness Tracking linker friendliness label Aug 9, 2020
@Pilchie Pilchie added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-routing labels Aug 10, 2020
@ghost
Copy link

ghost commented Aug 11, 2020

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@dotnet dotnet deleted a comment Aug 11, 2020
@SteveSandersonMS SteveSandersonMS added affected-few This issue impacts only small number of customers bug This issue describes a behavior which is not expected - a bug. severity-major This label is used by an internal tool labels Oct 7, 2020 — with ASP.NET Core Issue Ranking
@BrennanConroy BrennanConroy added area-servers and removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Mar 30, 2021
@ghost
Copy link

ghost commented Apr 20, 2021

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. Because it's not immediately obvious that this is a bug in our framework, we would like to keep this around to collect more feedback, which can later help us determine the impact of it. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@javiercn javiercn added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label May 6, 2021
@mkArtakMSFT mkArtakMSFT removed the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Aug 10, 2021
@adityamandaleeka adityamandaleeka added old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels and removed area-runtime old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels labels Aug 11, 2021
@Pilchie Pilchie added the old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels label Aug 13, 2021
@davidfowl
Copy link
Member Author

We should be able to close this one since we only use this path if runtime code generation is supported.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affected-few This issue impacts only small number of customers bug This issue describes a behavior which is not expected - a bug. feature-routing linker-friendliness Tracking linker friendliness old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels severity-major This label is used by an internal tool
Projects
None yet
Development

No branches or pull requests

9 participants