-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Allow pluggable Propagators for AspNetCore #28642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@alanwest @CodeBlanch from OpenTelemetry .NET group |
@cijothomas I think this will need to open another issue in the runtime repo and list there the complete proposal according the doc https://github.com/dotnet/runtime/blob/master/docs/project/api-review-process.md. you can then link this issue to the new one. |
Thanks. Will open related issue in runtime repo as well! |
Thanks for contacting us. |
This was completed by #33777 |
Is your feature request related to a problem? Yes.
The issue is with the context propagation logic embedded within Asp.Net Core, HttpClient libraries. These libraries have a hard-coded propagation logic embedded inside them, which follows the W3CTraceContext protocol. However, this makes it hard for users who use non W3CTraceContext, as there is no way to "swap" the W3CTraceContext with something else.
Describe the solution you'd like
Let
DiagnosticSource
package expose a new Propagators API, ideally, in compliance with the OpenTelemetry specification for Propagators.. Here is the issue opened in runtime to track this - dotnet/runtime#46054Once this API is exposed by the runtime, modify AspNetCore (and HttpClient) to simply use these new Propagators API. The default Propagator can be the W3CTraceContext one itself, to ensure backward compatibility. But users can swap it with any custom propagators they chose.
Additional context
Related issue: #27237
Runtime issue: dotnet/runtime#46054
The text was updated successfully, but these errors were encountered: