Skip to content

Minimal APIs naming cleanup #35478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
halter73 opened this issue Aug 19, 2021 · 5 comments · Fixed by #35570
Closed

Minimal APIs naming cleanup #35478

halter73 opened this issue Aug 19, 2021 · 5 comments · Fixed by #35570
Assignees
Labels
api-approved API was approved in API review, it can be implemented area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc feature-minimal-actions Controller-like actions for endpoint routing
Milestone

Comments

@halter73
Copy link
Member

halter73 commented Aug 19, 2021

We should not use "Minimal" in any API names. We should also avoid the word "action" when defining minimal route handlers.

  1. MinimalActionEndpointRouteBuilderExtensions -> DelegateEndpointRouteBuilderExtensions
  2. MinimalActionEndpointConventionBuilder -> DelegateEndpointConventionBuilder
  3. Map(this IEndpointRouteBuilder endpoints, RoutePattern pattern, Delegate action) -> Map(this IEndpointRouteBuilder endpoints, RoutePattern pattern, Delegate handler)
  4. RequestDelegateFactory.Create(Delegate action, RequestDelegateFactoryOptions? options) -> RequestDelegateFactory.Create(Delegate handler, RequestDelegateFactoryOptions? options)
@halter73 halter73 added feature-minimal-actions Controller-like actions for endpoint routing area-runtime labels Aug 19, 2021
@halter73 halter73 added this to the 6.0-rc1 milestone Aug 19, 2021
@halter73 halter73 self-assigned this Aug 19, 2021
@halter73 halter73 added the api-suggestion Early API idea and discussion, it is NOT ready for implementation label Aug 19, 2021
@halter73 halter73 added api-ready-for-review API is ready for formal API review - https://github.com/dotnet/apireviews and removed api-suggestion Early API idea and discussion, it is NOT ready for implementation labels Aug 20, 2021
@ghost
Copy link

ghost commented Aug 20, 2021

Thank you for submitting this for API review. This will be reviewed by @dotnet/aspnet-api-review at the next meeting of the ASP.NET Core API Review group. Please ensure you take a look at the API review process documentation and ensure that:

  • The PR contains changes to the reference-assembly that describe the API change. Or, you have included a snippet of reference-assembly-style code that illustrates the API change.
  • The PR describes the impact to users, both positive (useful new APIs) and negative (breaking changes).
  • Someone is assigned to "champion" this change in the meeting, and they understand the impact and design of the change.

@ghost
Copy link

ghost commented Aug 21, 2021

Thank you for submitting this for API review. This will be reviewed by @dotnet/aspnet-api-review at the next meeting of the ASP.NET Core API Review group. Please ensure you take a look at the API review process documentation and ensure that:

  • The PR contains changes to the reference-assembly that describe the API change. Or, you have included a snippet of reference-assembly-style code that illustrates the API change.
  • The PR describes the impact to users, both positive (useful new APIs) and negative (breaking changes).
  • Someone is assigned to "champion" this change in the meeting, and they understand the impact and design of the change.

@halter73 halter73 reopened this Aug 23, 2021
@ghost
Copy link

ghost commented Aug 23, 2021

Thank you for submitting this for API review. This will be reviewed by @dotnet/aspnet-api-review at the next meeting of the ASP.NET Core API Review group. Please ensure you take a look at the API review process documentation and ensure that:

  • The PR contains changes to the reference-assembly that describe the API change. Or, you have included a snippet of reference-assembly-style code that illustrates the API change.
  • The PR describes the impact to users, both positive (useful new APIs) and negative (breaking changes).
  • Someone is assigned to "champion" this change in the meeting, and they understand the impact and design of the change.

1 similar comment
@ghost
Copy link

ghost commented Aug 23, 2021

Thank you for submitting this for API review. This will be reviewed by @dotnet/aspnet-api-review at the next meeting of the ASP.NET Core API Review group. Please ensure you take a look at the API review process documentation and ensure that:

  • The PR contains changes to the reference-assembly that describe the API change. Or, you have included a snippet of reference-assembly-style code that illustrates the API change.
  • The PR describes the impact to users, both positive (useful new APIs) and negative (breaking changes).
  • Someone is assigned to "champion" this change in the meeting, and they understand the impact and design of the change.

@pranavkm pranavkm added api-approved API was approved in API review, it can be implemented and removed api-ready-for-review API is ready for formal API review - https://github.com/dotnet/apireviews labels Aug 23, 2021
@halter73
Copy link
Member Author

The rename was merged into rc1 by #35632.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 23, 2021
@amcasey amcasey added area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc and removed area-runtime labels Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api-approved API was approved in API review, it can be implemented area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc feature-minimal-actions Controller-like actions for endpoint routing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants