-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Cache IResult types for well known status codes and results without parameters #39951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I have started look this issue and those are the status/results that I am planning to have a PR to cache: Always cache:
Cache when no content (No parameters)
|
Also any know status code. |
@davidfowl is this list good enough:
Or, you want a cache for every known status code listed here (maybe it is too much 😂): I am planning to have an |
Everything in that class. |
@davidfowl @brunolins16 Do you think we should codegen this? I'm not sure how much we do that kind of thing outside of Kestrel. |
@halter73 I am benchmarking different ideas for the caching, but I have a feeling that it might be a good idea to codegen whatever idea we end up with. |
Yes please t4? |
Is there an existing issue for this?
Is your feature request related to a problem? Please describe the problem.
We should optimize result allocation by caching common result instances (known status codes etc).
Describe the solution you'd like
Caching of these result types.
Additional context
No response
The text was updated successfully, but these errors were encountered: