Pull request builds run out of disk space in Azure Pipelines

[natemcmaster]

PRs against the master branch currently fail because the Hosted VS2017 image has limited disk space

System.IO.IOException : There is not enough space on the disk

Options:

• Switch to a new queue. I tried dotnet-external-temp, but this doesn't have VS C++ tooling installed
• Work with @dotnet/dnceng to create a new pool
• Don't run tests on PRs?

cc @chcosta @Chrisboh - in case you have other ideas for options available to us.

[chcosta]

Which "VS C++" tooling is missing? I thought we installed all of the VS workloads on the dotnet-external-temp pool.

@riarenas

[riarenas]

`dotnet-external-temp pool is supposed to have a full install of vs2017. we've had some issues with some of the optional components for the different workloads not being there, but we should be able to add any that are missing. Can you tell what exactly is missing from them?

[riarenas]

We also have a special pool: AspNetCore-VS2017 where the components in the pool were specifically tailored for ASPNet, is there something missing from that pool?

[natemcmaster]

AspNetCore-VS2017 is only for internal builds.

We use VSWhere to search for a VS installation with these required workloads. When we do so, vswhere says there is not compatible installation.

• Microsoft.VisualStudio.Component.VSSDK
• Microsoft.VisualStudio.Component.VC.Tools.x86.x64
• Microsoft.VisualStudio.ComponentGroup.NativeDesktop.Win81
• Microsoft.VisualStudio.Component.VC.ATL
• Microsoft.VisualStudio.Component.Windows10SDK.15063.Desktop

We're also looking for VS >= 15.8.

[riarenas]

I created #dotnet/core-eng#4674 so we can verify that we install everything you need in the dotnet-external-temp pool.

[chcosta]

What else is AspNetCore-VS2017 doing that is missing from dotnet-internal-temp? Are those signing machines? I'm wondering if we can unify on dotnet-internal-temp but the signing thing may still need to be sorted for Asp.Net.

[chcosta]

Also, we should add the same workloads, regardless, to dotnet-internal-temp. It's a little weird to have support for them in the external pool but not the internal pool

[natemcmaster]

AspNetCore-VS2017 is half-complete and currently unused. We got it mostly ready to use before we punted all AzDO migration work to post-2.2. The things we had left to figure out were JDK and Code signing.

At this point, we could probably kill that queue entirely and use dotnet-internal-temp.

[natemcmaster]

Still blocked on https://github.com/dotnet/core-eng/issues/4764

[natemcmaster]

At this point, space issues should no longer affect Windows.

For 2.x, we need to switch to new Linux queues, which I believe should be available now.

[natemcmaster]

@dougbu let's chat about this one. The code change should be minimal, but requires context to know which line to change.

[dougbu]

For 2.x, we need to switch to new Linux queues, which I believe should be available now.

Now using new queues in 2.x branches.