Skip to content

DeveloperExceptionMiddleware shouldn't have dependencies to ProblemDetails #46339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task done
brunolins16 opened this issue Jan 31, 2023 · 4 comments
Open
1 task done
Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc feature-problem-details
Milestone

Comments

@brunolins16
Copy link
Member

brunolins16 commented Jan 31, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

In #42212 was introduced the IProblemDetailsService and the DeveloperExceptionPageMiddleware updated to include ProblemDetails payload generation.

However, it introduced an unnecessary dependency to JsonOptions and ProblemDetails that could have been avoided if the the ProblemDetails generation was implemented using an IDeveloperPageExceptionFilter.

Expected Behavior

DeveloperExceptionPageMiddleware should not have dependencies to JsonOptions or ProblemDetails but should have the ProblemDetails payload generated when AddProblemDetails is called.

.NET Version

.NET 7

@captainsafia
Copy link
Member

Triage: @mitchdenny As part of #46969, can you see if ProblemDetails is a big contributor to the size accounting for DeveloperExceptionPage? If it is a big contributor, we may consider doing this work.

@mitchdenny mitchdenny self-assigned this Mar 16, 2023
@adityamandaleeka adityamandaleeka added this to the .NET 8 Planning milestone Mar 30, 2023
@ghost
Copy link

ghost commented Mar 30, 2023

Thanks for contacting us.

We're moving this issue to the .NET 8 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@amcasey amcasey added area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares labels Jun 2, 2023
@captainsafia captainsafia removed the old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels label Jun 6, 2023
@mitchdenny mitchdenny removed their assignment Jun 7, 2023
@mitchdenny mitchdenny modified the milestones: .NET 8 Planning, Backlog Jun 7, 2023
@ghost
Copy link

ghost commented Jun 7, 2023

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@mitchdenny
Copy link
Member

Moving to backlog due to reprioritization.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc feature-problem-details
Projects
No open projects
Status: No status
Development

No branches or pull requests

6 participants