-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Add support for X509 client certificate "authentication" #4663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We've moved this issue is in the Backlog milestone. This means that it is not going to happen for the coming release. We will re-assess the backlog following the current release and consider this item at that time. However, keep in mind that there are many other high priority features with which it will be competing for resources. |
I am also looking for this handler. Thanks |
@Eilon I'm putting this into 3.0, it shouldn't take that much time, I already have tests, we'd just need to do the reassignment, because this was done out of work hours. |
@blowdart - do you already have a sample of this somewhere? We're concerned this might be a big cost to bring up to production, including testing. We can discuss more when you're back. |
Who is "we" in this case? Damian allowed approved it. It's be a matter of moving https://github.com/blowdart/idunno.Authentication/tree/master/src/idunno.Authentication.Certificate and testing some more |
Thanks for the link. When you're back let's discuss exactly what needs to be done in terms of test coverage. |
I have written a Client Cert Middleware too basically maps certs to Roles using configuration settings, example json setting.
|
@HaoK said he should be able to take a look at this since @Tratcher is deep in Kerberos land now ;). It's in preview 5 right now, but it can certainly be moved (fyi @ajcvickers @Eilon). Also, we should support the |
Note if we support |
@HaoK , I believe this is on your plate now? |
Client certificates are a commonly used way to authenticate gRPC service clients. We'll be interested in using this middleware in our documentation and tutorials. |
It's important for a number of enterprise and financial API / OAuth scenarios.
@blowdart already has 85% of it done - please include that in ASP.NET itself.
The text was updated successfully, but these errors were encountered: