Skip to content

Replace internal Microsoft.Extensions.Metrics with package #47618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JamesNK opened this issue Apr 10, 2023 · 3 comments
Closed

Replace internal Microsoft.Extensions.Metrics with package #47618

JamesNK opened this issue Apr 10, 2023 · 3 comments
Assignees
@JamesNK
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Milestone
8.0-preview5

Comments

@JamesNK
Copy link
Member

JamesNK commented Apr 10, 2023

#46834 adds an internal prototype version of Microsoft.Extensions.Metrics. The types are shared throughout ASP.NET Core with InternalsVisibleTo.

Replace with Microsoft.Extensions.Metrics when available. This work is happening in dotnet/runtime#77514
@JamesNK JamesNK added this to the .NET 8.0 milestone Apr 10, 2023
@JamesNK JamesNK mentioned this issue Apr 10, 2023
Merged
@JamesNK JamesNK self-assigned this Apr 10, 2023
@JamesNK JamesNK mentioned this issue Apr 18, 2023
Closed
12 tasks
@adityamandaleeka adityamandaleeka modified the milestones: .NET 8.0, 8.0-preview5 Apr 26, 2023
@JamesNK JamesNK added the blocked The work on this issue is blocked due to some dependency label May 9, 2023
@JamesNK
Copy link
Member Author

JamesNK commented May 9, 2023

Blocked, waiting on dotnet/runtime#77514 to be completed.

@JamesNK JamesNK mentioned this issue May 24, 2023
Closed
@eerhardt
Copy link
Member

Fixed by #48407.

@JamesNK
Copy link
Member Author

JamesNK commented May 26, 2023

@eerhardt Thanks for shepherding this through for preview 5! I was planning to wait for 6, but I didn't think about type name conflicts showing up when the real version was merged.

@adityamandaleeka adityamandaleeka removed the blocked The work on this issue is blocked due to some dependency label May 30, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 29, 2023
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JamesNK JamesNK

Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
8.0-preview5
Development

Successfully merging a pull request may close this issue.

Use Microsoft.Extensions.Diagnostics dotnet/aspnetcore
4 participants
@adityamandaleeka @JamesNK @eerhardt @amcasey