Skip to content

DocumentSnapshot system needs to understands imports better #5095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NTaylorMullen opened this issue Oct 5, 2018 · 3 comments
Closed

DocumentSnapshot system needs to understands imports better #5095

NTaylorMullen opened this issue Oct 5, 2018 · 3 comments
Assignees
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-razor-pages Needs: Design This issue requires design work before implementating.
Milestone

Comments

@NTaylorMullen
Copy link

tl;dr; Getting imports today isn't guaranteed to be correct in the DocumentSnapshot world.

When you go through the process of adding documents to the project system you can get into an invalid state where documents you pull from the project system may generate invalid output. Basically, adding all .cshtml files => generating their output and then adding a _ViewImports.cshtml to the project system results in all of the previous files not seeing the _ViewImports.cshtml file.

So we need to design some mechanism when every time an important import file enters the system the ProjectSnapshotManager needs to update all documents in the project to be aware.

This isn't an issue in VS windows today because we don't rely on the DocumentSnapshot system for import updates.

/cc @rynowak @ajaybhargavb

@NTaylorMullen NTaylorMullen self-assigned this Oct 5, 2018
@rynowak
Copy link
Member

rynowak commented Oct 6, 2018

I don't think this is 'needs design' - this is something that is intended to work with the current system.

@aspnet-hello aspnet-hello transferred this issue from aspnet/Razor Dec 14, 2018
@aspnet-hello aspnet-hello added this to the 3.0.0 milestone Dec 14, 2018
@aspnet-hello aspnet-hello added 1 - Ready area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-razor-pages Needs: Design This issue requires design work before implementating. labels Dec 14, 2018
@mkArtakMSFT
Copy link
Contributor

Doesn't seem like we need this nor we heard asks from customers on this.

@mkArtakMSFT
Copy link
Contributor

Please reopen, if it's important.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-razor-pages Needs: Design This issue requires design work before implementating.
Projects
None yet
Development

No branches or pull requests

4 participants