Skip to content

Add template parameter for cookie consent UI to Web Application project template #5444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DamianEdwards opened this issue Oct 18, 2018 · 5 comments
Closed

Add template parameter for cookie consent UI to Web Application project template #5444

DamianEdwards opened this issue Oct 18, 2018 · 5 comments
Assignees
@ryanbrandenburg
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one ✔️ Resolution: Won't Fix Resolved because we decided not to change the behavior reported in this issue.
Milestone
3.0.0-preview7

Comments

@DamianEdwards
Copy link
Member

The cookie consent UI in the web application template should be an option in the web application template. I'd make it off by default at the cmd line, and on by default in VS. The option should be visualized in VS with a checkbox. Disabling the option should remove:

  • _CookieConsentPartial.cshtml
  • The app.UseCookiePolicy() line in Startup.cs (and associated using)
  • The services.Configure<CookiePolicyOptions> call in Startup.cs (and associated using)
  • The <partial name="_CookieConsentPartial" /> line in _Layout.cshtml

@danroth27
@aspnet-hello aspnet-hello transferred this issue from aspnet/Templating Dec 17, 2018
@aspnet-hello aspnet-hello assigned danroth27 and unassigned danroth27 Dec 17, 2018
@aspnet-hello aspnet-hello added this to the 3.0.0-preview1 milestone Dec 17, 2018
@aspnet-hello aspnet-hello added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one Needs: Spec Indicates that a spec defining user experience is required labels Dec 17, 2018
@Eilon Eilon modified the milestones: 3.0.0-preview1, 3.0.0-preview2 Dec 18, 2018
@mkArtakMSFT
Copy link
Contributor

@danroth27 , you define the priority for this, please.

@mkArtakMSFT
Copy link
Contributor

@Eilon FYI

@mkArtakMSFT mkArtakMSFT added 1 - Ready and removed Needs: Spec Indicates that a spec defining user experience is required labels Mar 7, 2019
@mkArtakMSFT
Copy link
Contributor

@danroth27, there is a tooling aspect here. Can you please handle that with the tooling team? We'll do the rest as part of this work item.

@danroth27
Copy link
Member

Yes, we've already brought this up with the tooling folks. We just need to firm up the plans.

@mkArtakMSFT
Copy link
Contributor

This is actually mentioned in the #9937, where we've decided to turn this into a doc instead of bringing in an option.

@ryanbrandenburg ryanbrandenburg added the ✔️ Resolution: Won't Fix Resolved because we decided not to change the behavior reported in this issue. label Jun 25, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ryanbrandenburg ryanbrandenburg

Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one ✔️ Resolution: Won't Fix Resolved because we decided not to change the behavior reported in this issue.
Projects
None yet
Milestone
3.0.0-preview7
Development

No branches or pull requests
6 participants
@Eilon @DamianEdwards @danroth27 @ryanbrandenburg @mkArtakMSFT @aspnet-hello