-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Use TraceIdentifier of HttpContext as a span in W3C when possible #5927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Epic #8924 |
Waiting on an API on Activity to allow us to set the ID when we have one from the hosting server (IIS, etc.). Moved to 3.1 until we have this API. |
@SergeyKanzhelev after looking at things I agree we should have a plan for this (hopefully as part of 3.0 even if execution happens in 3.1). Right now with activities and w3c, there's no good place to store the trace identifier so that it flows with the activity. (I'm not even sure if the format will align in all cases, but maybe we can make it) |
Heya, coming late to this: has been any movement on it? Can middleware change this and start a new Activity and have that somehow replace the TraceIdentifier more or less automatically? |
@kzu Hosting already does this. We already create a new Activity for each request and set the parent id and trace state if the right headers were present on the incoming request. We've also already changed the default activity format to W3C. |
@davidfowl @tarekgh Is there any work left here or is this issue good to close? |
I think this can be closed. CC @noahfalk |
Motivation
TraceIdentifier is represented as a unique string. Implementation of TraceIdentifier should be aligned with migration to W3C. TraceIdentifier should match the
span-ID
in W3C distributed tracing context when possible.CC: @seth-capistron, @vancem, @jacpull, @lmolkova, @glennc, @davidfowl
The text was updated successfully, but these errors were encountered: