Skip to content

Use TraceIdentifier of HttpContext as a span in W3C when possible #5927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SergeyKanzhelev opened this issue Jun 12, 2018 · 8 comments
Closed
Labels
area-hosting Includes Hosting area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions enhancement This issue represents an ask for new feature or an enhancement to an existing one
Milestone

Comments

@SergeyKanzhelev
Copy link

Motivation

TraceIdentifier is represented as a unique string. Implementation of TraceIdentifier should be aligned with migration to W3C. TraceIdentifier should match the span-ID in W3C distributed tracing context when possible.

CC: @seth-capistron, @vancem, @jacpull, @lmolkova, @glennc, @davidfowl

@aspnet-hello aspnet-hello transferred this issue from aspnet/Hosting Dec 18, 2018
@aspnet-hello aspnet-hello added this to the 3.0.0 milestone Dec 18, 2018
@aspnet-hello aspnet-hello added area-hosting enhancement This issue represents an ask for new feature or an enhancement to an existing one labels Dec 18, 2018
@muratg
Copy link
Contributor

muratg commented Jan 9, 2019

cc @shirhatti @davidfowl @Tratcher

@analogrelay
Copy link
Contributor

Epic #8924

@analogrelay
Copy link
Contributor

Waiting on an API on Activity to allow us to set the ID when we have one from the hosting server (IIS, etc.). Moved to 3.1 until we have this API.

@davidfowl
Copy link
Member

davidfowl commented Apr 14, 2019

@SergeyKanzhelev after looking at things I agree we should have a plan for this (hopefully as part of 3.0 even if execution happens in 3.1). Right now with activities and w3c, there's no good place to store the trace identifier so that it flows with the activity. (I'm not even sure if the format will align in all cases, but maybe we can make it)

@analogrelay analogrelay modified the milestones: 3.1.0, Backlog Nov 6, 2019
@kzu
Copy link

kzu commented Jul 16, 2020

Heya, coming late to this: has been any movement on it? Can middleware change this and start a new Activity and have that somehow replace the TraceIdentifier more or less automatically?

@shirhatti
Copy link
Contributor

@kzu Hosting already does this. We already create a new Activity for each request and set the parent id and trace state if the right headers were present on the incoming request. We've also already changed the default activity format to W3C.

@shirhatti
Copy link
Contributor

@davidfowl @tarekgh Is there any work left here or is this issue good to close?

@tarekgh
Copy link
Member

tarekgh commented Jul 20, 2020

I think this can be closed.

CC @noahfalk

@ghost ghost locked as resolved and limited conversation to collaborators Aug 19, 2020
@amcasey amcasey added the area-hosting Includes Hosting label Jun 1, 2023
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-hosting Includes Hosting area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions enhancement This issue represents an ask for new feature or an enhancement to an existing one
Projects
None yet
Development

No branches or pull requests

10 participants