[Blazor] NavigationManager API consolidation: NotFound method => NotifyNotFound() + NotFoundEvent => NotFound

[hakenr]

Background and Motivation

I'm not sure how this got through the API review process (I'm not able to find the related discussion with possible justification), but the naming introduced in #60752 seems odd. The Event suffix in NotFoundEvent isn't commonly used in .NET APIs, and I believe it's considered inappropriate naming.

Proposed API

- public event EventHandler<EventArgs> NotFoundEvent
+ public event EventHandler<EventArgs> NotFound

- public virtual void NotFound()
+ public virtual void NotifyNotFound()

Reference

• https://learn.microsoft.com/en-us/dotnet/standard/design-guidelines/names-of-type-members#names-of-events
• https://learn.microsoft.com/en-us/dotnet/csharp/event-pattern

@ilonatommy @javiercn @SteveSandersonMS

(If you need a hand, I will prepare a PR for this.)

[javiercn]

@hakenr thanks for contacting us.

It hasn't gotten through API review yet. When it does, we'll adjust the naming based on whatever decision we make there.

Thanks for bringing this up.

[hakenr]

@javiercn Thanks for the clarification.
I appreciate you considering my suggestion during the review.

[javiercn]

I'm closing this issue as we are tracking changes #61133 in the API review issue.

I brought up these suggestions although I believe we settled on a slightly different option