Skip to content

Nginx tests fail in PR checks on macOS/Linux fail on AzDO #6508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
natemcmaster opened this issue Dec 14, 2018 · 3 comments
Closed

Nginx tests fail in PR checks on macOS/Linux fail on AzDO #6508

natemcmaster opened this issue Dec 14, 2018 · 3 comments
Assignees
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions Done This issue has been fixed

Comments

@natemcmaster
Copy link
Contributor

PR checks on AzDO for aspnet/AspNetCore are always failing because nginx is not installed.

It should be possible to just download nginx when the build agent initializes.

@Tratcher
Copy link
Member

Reference PR: #6054
https://dnceng.visualstudio.com/public/_build/results?buildId=61703&view=ms.vss-test-web.test-result-details

The test projects are split based on those that have been converted to refs and those that haven't. If any tests fail in the refs batch then the other set doesn't run. That's why we haven't see this failure reported more.

@natemcmaster
Copy link
Contributor Author

Yes, that looks like the right approach. Can you copy that install-nginx script into eng/scripts/?

@Eilon Eilon transferred this issue from another repository Jan 9, 2019
@Tratcher Tratcher added the Done This issue has been fixed label Jan 25, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions Done This issue has been fixed
Projects
None yet
Development

No branches or pull requests

4 participants