Skip to content

Figure out how to reconnect to circuits #7243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pranavkm opened this issue Feb 4, 2019 · 2 comments
Closed

Figure out how to reconnect to circuits #7243

pranavkm opened this issue Feb 4, 2019 · 2 comments
Assignees
@pranavkm
Labels
area-blazor Includes: Blazor, Razor Components enhancement This issue represents an ask for new feature or an enhancement to an existing one Needs: Design This issue requires design work before implementating.
Milestone
3.0.0-preview3

Comments

@pranavkm
Copy link
Contributor

pranavkm commented Feb 4, 2019

As part of of #6971, the circuit identifier is a Guid. We have to determine if this is a sufficiently random enough value to allow a client to reconnect to a server. It's effectively a session identifier and it's likely not enough to present the identifier in itself as evidence to reconnect to a circuit.
@pranavkm pranavkm added 1 - Ready Needs: Design This issue requires design work before implementating. enhancement This issue represents an ask for new feature or an enhancement to an existing one labels Feb 4, 2019
@pranavkm pranavkm added this to the 3.0.0-preview3 milestone Feb 4, 2019
@pranavkm pranavkm self-assigned this Feb 4, 2019
@pranavkm pranavkm mentioned this issue Feb 4, 2019
Merged
@muratg muratg added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Feb 4, 2019
@danroth27 danroth27 added the area-blazor Includes: Blazor, Razor Components label Feb 6, 2019
@danroth27
Copy link
Member

Dup of #5562

@rynowak
Copy link
Member

rynowak commented Feb 8, 2019 •
edited
Loading

We have to determine if this is a sufficiently random enough value to allow a client to reconnect to a server. It's effectively a session identifier and it's likely not enough to present the identifier in itself as evidence to reconnect to a circuit.

We almost certainly want something cryptographically strong, a guid is not. The choice of a guid for this was as a temporary unblocker.

@mkArtakMSFT mkArtakMSFT removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels May 9, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pranavkm pranavkm

Labels
area-blazor Includes: Blazor, Razor Components enhancement This issue represents an ask for new feature or an enhancement to an existing one Needs: Design This issue requires design work before implementating.
Projects
None yet
Milestone
3.0.0-preview3
Development

No branches or pull requests
5 participants
@pranavkm @rynowak @muratg @danroth27 @mkArtakMSFT