Skip to content

Add support for @namespace directive for components #8007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ajaybhargavb opened this issue Feb 27, 2019 · 5 comments · Fixed by dotnet/razor#504
Closed

Add support for @namespace directive for components #8007

ajaybhargavb opened this issue Feb 27, 2019 · 5 comments · Fixed by dotnet/razor#504
Assignees
Labels
area-blazor Includes: Blazor, Razor Components Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one

Comments

@ajaybhargavb
Copy link
Contributor

I'm not sure if this was intentional but looks like we don't really support namespace directive in component documents. To support this, we'll need to add a ComponentNamespaceDirective similar to ComponentPageDirective.

Although the behavior of this directive isn't any different from regular Mvc/Pages, we can't use the same type because the existing NamespaceDirective resides in Mvc.Razor.Extensions and we can't move it over to Razor.Language because it is not supported in 1.x apps.

Note: This is a prerequisite for supporting namespace directives with usings in #5577

cc @rynowak

@ajaybhargavb ajaybhargavb added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates type: Enhancement area-blazor Includes: Blazor, Razor Components labels Feb 27, 2019
@rynowak
Copy link
Member

rynowak commented Feb 27, 2019

Could we move it over to Razor.Language but only add it for Razor >= 2.0?

Either way we should support this.

@rynowak
Copy link
Member

rynowak commented Apr 21, 2019

@SteveSandersonMS @mkArtakMSFT @danroth27

We're getting LOTS of feedback about this gap now that components are based on namespaces. We need to do this for preview 6.

@SteveSandersonMS
Copy link
Member

Great, let's do it! I see it's labelled XS already.

@isc30
Copy link

isc30 commented Apr 22, 2019

Is it possible to grab a task like this (or another one) to contribute?
I would love to start some contributions here

@ajaybhargavb
Copy link
Contributor Author

@isc30 thanks for your interest in contributing. You can pick any of the tasks that are labelled up-for-grabs https://github.com/aspnet/AspNetCore/issues?q=is%3Aopen+is%3Aissue+label%3Aup-for-grabs+label%3Aarea-mvc

@ajaybhargavb ajaybhargavb added Done This issue has been fixed and removed 2 - Working labels May 1, 2019
@mkArtakMSFT mkArtakMSFT removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels May 9, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-blazor Includes: Blazor, Razor Components Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants