Skip to content

Remove the call to add HSTS middleware from the API project template #8533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DamianEdwards opened this issue Mar 14, 2019 · 5 comments
Closed

Remove the call to add HSTS middleware from the API project template #8533

DamianEdwards opened this issue Mar 14, 2019 · 5 comments
Assignees
@mkArtakMSFT
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Milestone
3.0.0-preview7

Comments

@DamianEdwards
Copy link
Member

HSTS is intended for browser scenarios, thus we should remove it from the API project template.
@DamianEdwards DamianEdwards added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Mar 14, 2019
@blowdart
Copy link
Contributor

Can we force those templates to be HTTPS only then? :)

@mkArtakMSFT mkArtakMSFT added bug This issue describes a behavior which is not expected - a bug. 1 - Ready labels Mar 20, 2019
@mkArtakMSFT mkArtakMSFT added this to the 3.0.0-preview6 milestone Mar 20, 2019
@mkArtakMSFT
Copy link
Contributor

@DamianEdwards, should we?

Can we force those templates to be HTTPS only then?

@DamianEdwards DamianEdwards mentioned this issue May 17, 2019
Closed
@cremor
Copy link
Contributor

cremor commented Jun 3, 2019

What about the new Swagger generation options (#7639)? When those are used to create a project with SwaggerUI, there is a use case for browser access.

@mkArtakMSFT mkArtakMSFT added Working blocked The work on this issue is blocked due to some dependency and removed 1 - Ready labels Jun 6, 2019
@mkArtakMSFT
Copy link
Contributor

@glennc and @blowdart waiting on resolution here from regarding the HTTPS enforcement statement above.

@mkArtakMSFT mkArtakMSFT mentioned this issue Jun 7, 2019
Closed
@mkArtakMSFT
Copy link
Contributor

Talked about this offline and the decision is to cover this as part of the docs, linked as a separate issue above.

@mkArtakMSFT mkArtakMSFT removed the blocked The work on this issue is blocked due to some dependency label Jun 7, 2019
@mkArtakMSFT mkArtakMSFT mentioned this issue Jun 7, 2019
Merged
@mkArtakMSFT mkArtakMSFT added Done This issue has been fixed and removed Working labels Jun 7, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mkArtakMSFT mkArtakMSFT

Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Projects
None yet
Milestone
3.0.0-preview7
Development

No branches or pull requests
5 participants
@cremor @DamianEdwards @blowdart @ryanbrandenburg @mkArtakMSFT